Bug 15074

Summary: Cairo GraphicsContext null-pointer dereferences (segfaults on many pages on Wikipedia and other sites)
Product: WebKit Reporter: Jasper Bryant-Greene <m>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: PC   
OS: Linux   
URL: http://en.wikipedia.org/wiki/Christine_Gambito
Attachments:
Description Flags
set paintingDisabled to true if passed a null PlatformGraphicsContext oliver: review+

Jasper Bryant-Greene
Reported 2007-08-24 22:54:21 PDT
Cairo's GraphicsContext doesn't set paintingDisabled to true if passed a null PlatformGraphicsContext. This results in many null-pointer dereferences. Other platforms such as Qt do set paintingDisabled to true if passed a null PlatformGraphicsContext. A patch is forthcoming.
Attachments
set paintingDisabled to true if passed a null PlatformGraphicsContext (1.49 KB, patch)
2007-08-24 23:00 PDT, Jasper Bryant-Greene 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jasper Bryant-Greene
Comment 1 2007-08-24 23:00:59 PDT
Created attachment 16116 [details] set paintingDisabled to true if passed a null PlatformGraphicsContext
Oliver Hunt
Comment 2 2007-08-24 23:08:23 PDT
I do find myself wondering why you'd get a null rendering context on wikipedia though
Jasper Bryant-Greene
Comment 3 2007-08-24 23:13:41 PDT
I've set the URL of this bug to a page that causes the problem on my build of WebKit. In order to get the cairo stuff to turn up in the backtrace, I had to remove -O2 from the compiler flags (which seems to be in there even when building debug on my system...) as I think the compiler was inlining the cairo-specific GraphicsContext methods.
Mark Rowe (bdash)
Comment 4 2007-08-25 05:41:32 PDT
Landed in r25237.
Note You need to log in before you can comment on or make changes to this bug.