Summary: | Begin work on supporting reply blocks in _WKRemoteObjectRegistry | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, commit-queue, thorton | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 150774 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Anders Carlsson
2015-10-30 16:15:42 PDT
Created attachment 264434 [details]
Patch
Attachment 264434 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:63: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264435 [details]
Patch
Attachment 264435 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:63: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 264435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264435&action=review > Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm:206 > + ? Committed r191831: <http://trac.webkit.org/changeset/191831> WebKit2.RemoteObjectRegistry API test fails every time now: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20%28Tests%29/builds/9526/steps/run-api-tests/logs/stdio Re-opened since this is blocked by bug 150774 Created attachment 264640 [details]
Patch
Attachment 264640 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:63: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r191919: <http://trac.webkit.org/changeset/191919> |