Bug 150739

Summary: Begin work on supporting reply blocks in _WKRemoteObjectRegistry
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 150774    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch thorton: review+

Description Anders Carlsson 2015-10-30 16:15:42 PDT 
Begin work on supporting reply blocks in _WKRemoteObjectRegistry
Comment 1 Anders Carlsson 2015-10-30 16:18:36 PDT 
Created attachment 264434 [details]
Patch
Comment 2 WebKit Commit Bot 2015-10-30 16:20:15 PDT 
Attachment 264434 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:63:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2015-10-30 16:22:15 PDT 
Created attachment 264435 [details]
Patch
Comment 4 WebKit Commit Bot 2015-10-30 16:25:29 PDT 
Attachment 264435 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:63:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Tim Horton 2015-10-30 16:31:07 PDT 
Comment on attachment 264435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264435&action=review

> Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm:206
> +

?
Comment 6 Anders Carlsson 2015-10-30 17:13:16 PDT 
Committed r191831: <http://trac.webkit.org/changeset/191831>
Comment 7 Alexey Proskuryakov 2015-10-31 16:21:28 PDT 
WebKit2.RemoteObjectRegistry API test fails every time now: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20%28Tests%29/builds/9526/steps/run-api-tests/logs/stdio
Comment 8 WebKit Commit Bot 2015-11-01 07:58:35 PST 
Re-opened since this is blocked by bug 150774
Comment 9 Alexey Proskuryakov 2015-11-01 08:03:06 PST 
Rolled out in r191857.
Comment 10 Anders Carlsson 2015-11-02 15:37:30 PST 
Created attachment 264640 [details]
Patch
Comment 11 WebKit Commit Bot 2015-11-02 15:39:45 PST 
Attachment 264640 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:63:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Anders Carlsson 2015-11-02 16:08:41 PST 
Committed r191919: <http://trac.webkit.org/changeset/191919>