Summary: | leaks seen in fast/css/variables tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | CSS | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, cdumez, darin, dbates, hyatt, joepeck | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2015-10-30 12:41:31 PDT
I suspect https://trac.webkit.org/changeset/201608 fixed this. However, I will wait and test. Nope, still see leaks. Created attachment 280523 [details]
Patch
I suspect the CSSParserValueList leaks were fixed by https://trac.webkit.org/changeset/201608 -- the patch fixes the String leaks that were still happening. Together the two changes have fixed all the leaks. Comment on attachment 280523 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280523&action=review > Source/WebCore/css/CSSPrimitiveValue.cpp:285 > + return true; > + default: > + return false; I'd list all the other types here instead of having a default case so we'll fail to compile if someone adds another type. Committed r201690: <http://trac.webkit.org/changeset/201690> |