|Summary:||CSSParserVariable leaks seen on leaks bots|
|Product:||WebKit||Reporter:||Joseph Pecoraro <joepeck>|
|Component:||WebCore Misc.||Assignee:||Joseph Pecoraro <joepeck>|
|Severity:||Normal||CC:||ap, commit-queue, darin, hyatt, joepeck|
|Version:||WebKit Nightly Build|
Description Joseph Pecoraro 2015-10-30 11:52:31 PDT
Comment 1 Joseph Pecoraro 2015-10-30 12:02:31 PDT
* STEPS TO REPRODUCE shell> run-webkit-tests --leaks -1 fast/css/variables
Comment 2 Joseph Pecoraro 2015-10-30 12:18:55 PDT
This gets most of the leaks, there are still others. I'll give some time to tracking them otherwise I'll just put this patch up.
Comment 3 Joseph Pecoraro 2015-10-30 12:28:19 PDT
There is a CSSParserValueList leak, which I suspect is happening from: CSSValueList::buildParserValueSubstitutingVariables CSSValueList::buildParserValueListSubstitutingVariables They call each other but in the error cases I don't think the CSSParserValueList created by buildParserValueSubstitutingVariables gets destroyed. I'll file a separate bug about this, since it is non-trivial for me but probably easy for those familiar with what this code is doing.
Comment 4 Joseph Pecoraro 2015-10-30 12:37:02 PDT
Created attachment 264410 [details] [PATCH] Proposed Fix
Comment 5 WebKit Commit Bot 2015-10-30 16:19:17 PDT
Comment on attachment 264410 [details] [PATCH] Proposed Fix Clearing flags on attachment: 264410 Committed r191825: <http://trac.webkit.org/changeset/191825>
Comment 6 WebKit Commit Bot 2015-10-30 16:19:21 PDT
All reviewed patches have been landed. Closing bug.