Bug 150722

Summary: Minor CGColor leaks seen on bots allocated in WebSystemBackdropLayer.mm
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-10-30 11:05:52 PDT 
Minor CGColor leaks seen on bots allocated in WebSystemBackdropLayer.mm

* LEAK
Call stack: [thread 0x11decb300]: 
    | 0x2 
    | start 
    | main DumpRenderTreeMain.mm:30 
    | DumpRenderTreeMain(int, char const**) DumpRenderTree.mm:1430 
    | dumpRenderTree(int, char const**) DumpRenderTree.mm:1295 
    | runTestingServerLoop() DumpRenderTree.mm:1186 
    | runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) DumpRenderTree.mm:2036 
    | CFRunLoopRunSpecific 
    | __CFRunLoopRun 
    | __CFRunLoopDoSources0 
    | __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 
    | MultiplexerSource::_perform(void*) 
    | MultiplexerSource::perform() 
    | RunloopBlockContext::perform() 
    | CFArrayApplyFunction 
    | RunloopBlockContext::_invoke_block(void const*, void*) 
    | ___ZN27URLConnectionClient_Classic18_withDelegateAsyncEPKcU13block_pointerFvP16_CFURLConnectionPK33CFURLConnectionClientCurrent_VMaxE_block_invoke_2 
    | ___ZN27URLConnectionClient_Classic26_delegate_didFinishLoadingEU13block_pointerFvvE_block_invoke 
    | -[NSURLConnectionInternal _withActiveConnectionAndDelegate:] 
    | -[NSURLConnectionInternal _withConnectionAndDelegate:onlyActive:] 
    | __65-[NSURLConnectionInternal _withConnectionAndDelegate:onlyActive:]_block_invoke 
    | -[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:] WebCoreResourceHandleAsDelegate.mm:258 
    | WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) ResourceLoader.cpp:639 
    | WebCore::SubresourceLoader::didFinishLoading(double) SubresourceLoader.cpp:374 
    | WebCore::CachedRawResource::finishLoading(WebCore::SharedBuffer*) CachedRawResource.cpp:104 
    | WebCore::CachedResource::finishLoading(WebCore::SharedBuffer*) CachedResource.cpp:314 
    | WebCore::CachedResource::checkNotify() CachedResource.cpp:296 
    | WebCore::DocumentLoader::notifyFinished(WebCore::CachedResource*) DocumentLoader.cpp:385 
    | WebCore::DocumentLoader::finishedLoading(double) DocumentLoader.cpp:438 
    | WebCore::DocumentWriter::end() DocumentWriter.cpp:247 
    | WebCore::HTMLDocumentParser::finish() HTMLDocumentParser.cpp:452 
    | WebCore::HTMLDocumentParser::attemptToEnd() HTMLDocumentParser.cpp:424 
    | WebCore::HTMLDocumentParser::prepareToStopParsing() HTMLDocumentParser.cpp:133 
    | WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd() HTMLDocumentParser.cpp:412 
    | WebCore::HTMLDocumentParser::end() HTMLDocumentParser.cpp:403 
    | WebCore::HTMLTreeBuilder::finished() HTMLTreeBuilder.cpp:2939 
    | WebCore::HTMLConstructionSite::finishedParsing() HTMLConstructionSite.cpp:404 
    | WebCore::Document::finishedParsing() Document.cpp:4897 
    | WebCore::FrameLoader::finishedParsing() FrameLoader.cpp:758 
    | WebCore::FrameLoader::checkCompleted() FrameLoader.cpp:837 
    | WebCore::FrameLoader::checkCallImplicitClose() FrameLoader.cpp:890 
    | WebCore::Document::implicitClose() Document.cpp:2663 
    | WebCore::Document::dispatchWindowLoadEvent() Document.cpp:4067 
    | WebCore::DOMWindow::dispatchLoadEvent() DOMWindow.cpp:1884 
    | WebCore::DOMWindow::dispatchEvent(WTF::PassRefPtr<WebCore::Event>, WTF::PassRefPtr<WebCore::EventTarget>) DOMWindow.cpp:1926 
    | WebCore::EventTarget::fireEventListeners(WebCore::Event*) EventTarget.cpp:208 
    | WebCore::EventTarget::fireEventListeners(WebCore::Event*, WebCore::EventTargetData*, WTF::Vector<WebCore::RegisteredEventListener, 1ul, WTF::CrashOnOverflow, 16ul>&) EventTarget.cpp:256 
    | WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*) JSEventListener.cpp:130 
    | WebCore::JSMainThreadExecState::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) JSMainThreadExecState.h:56 
    | JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) CallData.cpp:44 
    | JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) CallData.cpp:39 
    | JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) Interpreter.cpp:1024 
    | JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) JITCode.cpp:80 
    | vmEntryToJavaScript 
    | llint_entry 
    | 0x47e9f4601028 
    | WebCore::jsInternalsPrototypeFunctionLayerTreeAsText(JSC::ExecState*) JSInternals.cpp:2779 
    | WebCore::Internals::layerTreeAsText(WebCore::Document*, int&) const Internals.cpp:1861 
    | WebCore::Internals::layerTreeAsText(WebCore::Document*, unsigned int, int&) const Internals.cpp:1884 
    | WebCore::Frame::layerTreeAsText(unsigned int) const Frame.cpp:929 
    | WebCore::RenderLayerCompositor::layerTreeAsText(unsigned int) RenderLayerCompositor.cpp:1860 
    | WebCore::RenderLayerCompositor::flushPendingLayerChanges(bool) RenderLayerCompositor.cpp:486 
    | WebCore::GraphicsLayerCA::flushCompositingState(WebCore::FloatRect const&, bool) GraphicsLayerCA.cpp:1100 
    | WebCore::GraphicsLayerCA::recursiveCommitChanges(WebCore::GraphicsLayerCA::CommitState const&, WebCore::TransformState const&, float, WebCore::FloatPoint const&, bool) GraphicsLayerCA.cpp:1387 
    | WebCore::GraphicsLayerCA::recursiveCommitChanges(WebCore::GraphicsLayerCA::CommitState const&, WebCore::TransformState const&, float, WebCore::FloatPoint const&, bool) GraphicsLayerCA.cpp:1387 
    | WebCore::GraphicsLayerCA::recursiveCommitChanges(WebCore::GraphicsLayerCA::CommitState const&, WebCore::TransformState const&, float, WebCore::FloatPoint const&, bool) GraphicsLayerCA.cpp:1374 
    | WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers(WebCore::GraphicsLayerCA::CommitState&, float, WebCore::FloatPoint const&) GraphicsLayerCA.cpp:1496 
    | WebCore::GraphicsLayerCA::changeLayerTypeTo(WebCore::PlatformCALayer::LayerType) GraphicsLayerCA.cpp:3361 
    | WebCore::GraphicsLayerCA::createPlatformCALayer(WebCore::PlatformCALayer::LayerType, WebCore::PlatformCALayerClient*) GraphicsLayerCA.cpp:332 
    | WebCore::PlatformCALayerCocoa::create(WebCore::PlatformCALayer::LayerType, WebCore::PlatformCALayerClient*) PlatformCALayerCocoa.mm:76 
    | WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa(WebCore::PlatformCALayer::LayerType, WebCore::PlatformCALayerClient*) PlatformCALayerCocoa.mm:278 
    | WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa(WebCore::PlatformCALayer::LayerType, WebCore::PlatformCALayerClient*) PlatformCALayerCocoa.mm:270 
    | -[WebLightSystemBackdropLayer init] WebSystemBackdropLayer.mm:54 
    | create_color 
    | CGTypeCreateInstance 
    | _CFRuntimeCreateInstance 
    | malloc_zone_malloc
Comment 1 Joseph Pecoraro 2015-10-30 11:06:48 PDT 
Created attachment 264403 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-10-30 12:10:03 PDT 
Comment on attachment 264403 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 264403

Committed r191804: <http://trac.webkit.org/changeset/191804>
Comment 3 WebKit Commit Bot 2015-10-30 12:10:07 PDT 
All reviewed patches have been landed.  Closing bug.