Bug 150700 – [Win] build-jsc and run-javascriptcore-tests do not work

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Brent Fulgham]

The "run-javascript-core" script does not work following our switch to CMake on Windows, because it attempts to build using the increasingly-out-of-date "Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.sln" solution to build the various pieces of JSC.

The actual failure was in the "build-jsc" script, which does not use the new CMake build system for Windows.

This patch corrects this oversight, allowing JSC developers to build only the JavaScript-related files. (820 files instead of 3500 files!)

[Brent Fulgham]

Created attachment 264365 [details]
Patch

[Mark Lam]

Comment on attachment 264365 [details]
Patch

r=me

[Alex Christensen]

lgtm, too

[Brent Fulgham]

The windows EWS failure looks like a bot problem. I'm investigating.

[Brent Fulgham]

Committed r191766: <http://trac.webkit.org/changeset/191766>

[Michael Saboff]

After this change, I now can't build JavaScriptCore or WebKit.  I get:
$ build-webkit --release --64-bit
Use of uninitialized value $expectedVersion in scalar chomp at Tools/Scripts/update-webkit-support-libs line 113.
Falling back to existing version of WebKitSupportLibrary.
Error: /home/msaboff/src/OpenSource/WebKitBuild/Release is not a directory

The directory does exist.

$ ls /home/msaboff/src/OpenSource/WebKitBuild/Release
ALL_BUILD.vcxproj*          cmakeconfig.h*            INSTALL.vcxproj*          RUN_TESTS.vcxproj*          x64/
ALL_BUILD.vcxproj.filters*  CMakeFiles/               INSTALL.vcxproj.filters*  RUN_TESTS.vcxproj.filters*  ZERO_CHECK.vcxproj*
bin64/                      CPackConfig.cmake*        lib32/                    Source/                     ZERO_CHECK.vcxproj.filters*
buildfailed*                CPackSourceConfig.cmake*  lib64/                    Tools/
build-webkit-options.txt    CTestTestfile.cmake*      obj64/                    WebKit.sln*
cmake_install.cmake*        DerivedSources/           PACKAGE.vcxproj*          webkit_errors.log*
CMakeCache.txt*             include/                  PACKAGE.vcxproj.filters*  webkit_warnings.log*


If I roll back to r191765, I can build.

[Brent Fulgham]

I'll fix ASAP!

[Csaba Osztrogonác]

(In reply to comment #5)
> Committed r191766: <http://trac.webkit.org/changeset/191766>

Apple Windows and WinCairo build is still broken.

[Brent Fulgham]

Committed r191793: <http://trac.webkit.org/changeset/191793>

[Csaba Osztrogonác]

(In reply to comment #9)
> Committed r191793: <http://trac.webkit.org/changeset/191793>

Originally you landed this change in r191766:

-    buildCMakeProjectOrExit(0, cmakeBasedPortName(), undef, "jsc $makeArgs", (cmakeBasedPortArguments(), $cmakeArgs));
+    my $testapi = (isAnyWindows() ? "testapi" : "");
+    buildCMakeProjectOrExit(0, cmakeBasedPortName(), undef, "jsc $testapi $makeArgs", (cmakeBasedPortArguments(), $cmakeArgs));

And this one in r191793:

-    # By default we build using all of the available CPUs
-    $makeArgs .= ($makeArgs ? " " : "") . "-j" . numberOfCPUs() if $makeArgs !~ /-j\s*\d+/;
+
+    my $buildTarget = "";
+    unless (isAnyWindows()) {
+        # By default we build using all of the available CPUs
+        $makeArgs .= ($makeArgs ? " " : "") . "-j" . numberOfCPUs() if $makeArgs !~ /-j\s*\d+/;
+        $buildTarget = "jsc $makeArgs";
+    } elsif (canUseNinja()) {
+        $buildTarget .= "jsc testapi";
+    }

Could you explain why -jN causes problem for Windows-ninja ?

[Csaba Osztrogonác]

Brent?

[Csaba Osztrogonác]

(In reply to comment #11)
> Brent?

ping?

[Csaba Osztrogonác]

(In reply to comment #11)
> Brent?

ping?

[Csaba Osztrogonác]

(In reply to comment #11)
> Brent?

ping?

[Csaba Osztrogonác]

(In reply to comment #11)
> Brent?

ping?

[Csaba Osztrogonác]

(In reply to comment #11)
> Brent?

ping?

[Csaba Osztrogonác]

Brent, it's not fair that you landed an unreviewed 
hack 2 weeks before and you don't answer my question.

Please answer as soon as possible.

[Csaba Osztrogonác]

ping?

[Alex Christensen]

The unless isAnyWindows is not necessary.  It works without it.  The canUseNinja is necessary because our bots use CMake and Visual Studio without Ninja.  If we change it, though, the testb3 that is there now shouldn't be a target on Windows because b3 isn't enabled on Windows.