Summary: | [Win] build-jsc and run-javascriptcore-tests do not work | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Tools / Tests | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, dbates, lforschler, mark.lam, msaboff, ossy, peavo | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Bug Depends on: | 150707 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Brent Fulgham
2015-10-29 16:41:49 PDT
Created attachment 264365 [details]
Patch
Comment on attachment 264365 [details]
Patch
r=me
lgtm, too The windows EWS failure looks like a bot problem. I'm investigating. Committed r191766: <http://trac.webkit.org/changeset/191766> After this change, I now can't build JavaScriptCore or WebKit. I get: $ build-webkit --release --64-bit Use of uninitialized value $expectedVersion in scalar chomp at Tools/Scripts/update-webkit-support-libs line 113. Falling back to existing version of WebKitSupportLibrary. Error: /home/msaboff/src/OpenSource/WebKitBuild/Release is not a directory The directory does exist. $ ls /home/msaboff/src/OpenSource/WebKitBuild/Release ALL_BUILD.vcxproj* cmakeconfig.h* INSTALL.vcxproj* RUN_TESTS.vcxproj* x64/ ALL_BUILD.vcxproj.filters* CMakeFiles/ INSTALL.vcxproj.filters* RUN_TESTS.vcxproj.filters* ZERO_CHECK.vcxproj* bin64/ CPackConfig.cmake* lib32/ Source/ ZERO_CHECK.vcxproj.filters* buildfailed* CPackSourceConfig.cmake* lib64/ Tools/ build-webkit-options.txt CTestTestfile.cmake* obj64/ WebKit.sln* cmake_install.cmake* DerivedSources/ PACKAGE.vcxproj* webkit_errors.log* CMakeCache.txt* include/ PACKAGE.vcxproj.filters* webkit_warnings.log* If I roll back to r191765, I can build. I'll fix ASAP! (In reply to comment #5) > Committed r191766: <http://trac.webkit.org/changeset/191766> Apple Windows and WinCairo build is still broken. Committed r191793: <http://trac.webkit.org/changeset/191793> (In reply to comment #9) > Committed r191793: <http://trac.webkit.org/changeset/191793> Originally you landed this change in r191766: - buildCMakeProjectOrExit(0, cmakeBasedPortName(), undef, "jsc $makeArgs", (cmakeBasedPortArguments(), $cmakeArgs)); + my $testapi = (isAnyWindows() ? "testapi" : ""); + buildCMakeProjectOrExit(0, cmakeBasedPortName(), undef, "jsc $testapi $makeArgs", (cmakeBasedPortArguments(), $cmakeArgs)); And this one in r191793: - # By default we build using all of the available CPUs - $makeArgs .= ($makeArgs ? " " : "") . "-j" . numberOfCPUs() if $makeArgs !~ /-j\s*\d+/; + + my $buildTarget = ""; + unless (isAnyWindows()) { + # By default we build using all of the available CPUs + $makeArgs .= ($makeArgs ? " " : "") . "-j" . numberOfCPUs() if $makeArgs !~ /-j\s*\d+/; + $buildTarget = "jsc $makeArgs"; + } elsif (canUseNinja()) { + $buildTarget .= "jsc testapi"; + } Could you explain why -jN causes problem for Windows-ninja ? Brent? (In reply to comment #11) > Brent? ping? (In reply to comment #11) > Brent? ping? (In reply to comment #11) > Brent? ping? (In reply to comment #11) > Brent? ping? (In reply to comment #11) > Brent? ping? Brent, it's not fair that you landed an unreviewed hack 2 weeks before and you don't answer my question. Please answer as soon as possible. ping? The unless isAnyWindows is not necessary. It works without it. The canUseNinja is necessary because our bots use CMake and Visual Studio without Ninja. If we change it, though, the testb3 that is there now shouldn't be a target on Windows because b3 isn't enabled on Windows. |