Bug 15068

Summary: [S60] VBRY-763RLF : RTL brackets and alt text are displayed incorrecting
Product: WebKit Reporter: Pat <vincent.bradley>
Component: DOMAssignee: Pat <vincent.bradley>
Status: CLOSED FIXED    
Severity: Major Keywords: PlatformOnly
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: S60 Emulator   
OS: S60 3rd edition   
URL: http://www.google.com/pk or http://www.google.co.il
Attachments:
Description Flags
3.2 patch for RTL text in body and alt text
yongjun.zhang: review-
3.2 patch for RTL text in body and alt image text yongjun.zhang: review+

Description Pat 2007-08-24 05:46:23 PDT
TSW ID: VBRY-763RLF
For RTL languages, special characters, such as brackets are displayed incorrectly. Also Alternative text for images are displayed LTR, instead of RTL. The alt text issue is on Safari also, but they always display a broken image icon, so the text is not displayed.
Comment 1 Pat 2007-08-27 08:46:22 PDT
Created attachment 16132 [details]
3.2 patch for RTL text in body and alt text

This patch needs to be reviewed by Sachin (WebKit part) and Zalan (WebCore part).
Comment 2 Pat 2007-08-27 11:39:14 PDT
Comment on attachment 16132 [details]
3.2 patch for RTL text in body and alt text

Sachin requested that Yongjun review the WebKit part of patch, since he wrote that module. Reassigning review to Yongjun.
Comment 3 Yongjun Zhang 2007-09-05 13:31:01 PDT
Comment on attachment 16132 [details]
3.2 patch for RTL text in body and alt text

Possible memory leak here:
+                // We have a RTL string
+                TBidiText* bidiText = TBidiText::NewL( newStr, 1, TBidiText::ERightToLeft );
+                bidiText->WrapText( WidthForRun( aRun, aStyle ), *iFont );
+                bidiText->DrawText( bitgc, startPos );

/ bidiText is never deleted.
Comment 4 Pat 2007-09-07 10:36:19 PDT
Created attachment 16219 [details]
3.2 patch for RTL text in body and alt image text

Fixes memory leak, by deleting TBidiText.
Comment 5 Yongjun Zhang 2007-09-10 07:06:04 PDT
Comment on attachment 16219 [details]
3.2 patch for RTL text in body and alt image text

r = me
Comment 6 Bradley Morrison 2008-04-09 11:39:57 PDT
Bulk closing of all s60 platform bugs. 

Sorry for the noise!
Comment 7 Joel Parks 2011-03-21 11:53:37 PDT
re-purposing InTSW keyword for use by QtWebkit team