Summary: | [S60] VBRY-763RLF : RTL brackets and alt text are displayed incorrecting | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pat <vincent.bradley> | ||||||
Component: | DOM | Assignee: | Pat <vincent.bradley> | ||||||
Status: | CLOSED FIXED | ||||||||
Severity: | Major | Keywords: | PlatformOnly | ||||||
Priority: | P2 | ||||||||
Version: | 523.x (Safari 3) | ||||||||
Hardware: | S60 Emulator | ||||||||
OS: | S60 3rd edition | ||||||||
URL: | http://www.google.com/pk or http://www.google.co.il | ||||||||
Attachments: |
|
Description
Pat
2007-08-24 05:46:23 PDT
Created attachment 16132 [details]
3.2 patch for RTL text in body and alt text
This patch needs to be reviewed by Sachin (WebKit part) and Zalan (WebCore part).
Comment on attachment 16132 [details]
3.2 patch for RTL text in body and alt text
Sachin requested that Yongjun review the WebKit part of patch, since he wrote that module. Reassigning review to Yongjun.
Comment on attachment 16132 [details]
3.2 patch for RTL text in body and alt text
Possible memory leak here:
+ // We have a RTL string
+ TBidiText* bidiText = TBidiText::NewL( newStr, 1, TBidiText::ERightToLeft );
+ bidiText->WrapText( WidthForRun( aRun, aStyle ), *iFont );
+ bidiText->DrawText( bitgc, startPos );
/ bidiText is never deleted.
Created attachment 16219 [details]
3.2 patch for RTL text in body and alt image text
Fixes memory leak, by deleting TBidiText.
Comment on attachment 16219 [details]
3.2 patch for RTL text in body and alt image text
r = me
Bulk closing of all s60 platform bugs. Sorry for the noise! re-purposing InTSW keyword for use by QtWebkit team |