[JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

We check it only to wipe the directory or not, but we are still tryihng to update every module even when the configuration hasn't changed. This is problematic because it makes the whole build fail when any repository fails to checkout an already checked out revision, because the server is down for example. This is even more problematic for the bots that skip perfectly valid revisions.

[Carlos Garcia Campos]

Created attachment 264308 [details]
Patch

[Csaba Osztrogonác]

The idea is good to fix this issue. I have only one issue with this change.
If I would like to build an optional module (llvm is optional now),
update-webkitefl-libs llvm-for-X86_64 wouldn't do anything. It would
be great to fix it somehow.

[Carlos Garcia Campos]

Ah, you are right, I forgot about the optional modules. We could either generate a md5 file for the optional moduleset file too or even better add an option --force since optional modules are supposed to be always built manually, no?

[Csaba Osztrogonác]

(In reply to comment #3)
> Ah, you are right, I forgot about the optional modules. We could either
> generate a md5 file for the optional moduleset file too or even better add
> an option --force since optional modules are supposed to be always built
> manually, no?

I think --force option is more than enough. ;)

[Carlos Garcia Campos]

Created attachment 264383 [details]
Added --force option

[Csaba Osztrogonác]

Comment on attachment 264383 [details]
Added --force option

LGTM, thanks.

[WebKit Commit Bot]

Comment on attachment 264383 [details]
Added --force option

Clearing flags on attachment: 264383

Committed r191784: <http://trac.webkit.org/changeset/191784>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.