Bug 150665

Summary: [JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, lforschler, mrobinson, ossy, zan
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Added --force option none

Carlos Garcia Campos
Reported 2015-10-29 03:16:56 PDT
We check it only to wipe the directory or not, but we are still tryihng to update every module even when the configuration hasn't changed. This is problematic because it makes the whole build fail when any repository fails to checkout an already checked out revision, because the server is down for example. This is even more problematic for the bots that skip perfectly valid revisions.
Attachments
Patch (2.84 KB, patch)
2015-10-29 03:20 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Added --force option (3.48 KB, patch)
2015-10-29 23:55 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-10-29 03:20:56 PDT
Created attachment 264308 [details] Patch
Csaba Osztrogonác
Comment 2 2015-10-29 03:35:10 PDT
The idea is good to fix this issue. I have only one issue with this change. If I would like to build an optional module (llvm is optional now), update-webkitefl-libs llvm-for-X86_64 wouldn't do anything. It would be great to fix it somehow.
Carlos Garcia Campos
Comment 3 2015-10-29 04:15:01 PDT
Ah, you are right, I forgot about the optional modules. We could either generate a md5 file for the optional moduleset file too or even better add an option --force since optional modules are supposed to be always built manually, no?
Csaba Osztrogonác
Comment 4 2015-10-29 06:23:22 PDT
(In reply to comment #3) > Ah, you are right, I forgot about the optional modules. We could either > generate a md5 file for the optional moduleset file too or even better add > an option --force since optional modules are supposed to be always built > manually, no? I think --force option is more than enough. ;)
Carlos Garcia Campos
Comment 5 2015-10-29 23:55:16 PDT
Created attachment 264383 [details] Added --force option
Csaba Osztrogonác
Comment 6 2015-10-30 00:23:46 PDT
Comment on attachment 264383 [details] Added --force option LGTM, thanks.
WebKit Commit Bot
Comment 7 2015-10-30 01:48:57 PDT
Comment on attachment 264383 [details] Added --force option Clearing flags on attachment: 264383 Committed r191784: <http://trac.webkit.org/changeset/191784>
WebKit Commit Bot
Comment 8 2015-10-30 01:49:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.