Summary: | Crash making a tail call from a getter to a host function | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||||||||||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | benjamin, buildbot, fpizlo, ggaren, keith_miller, mark.lam, rniwa, saam | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Attachments: |
|
Description
Michael Saboff
2015-10-28 22:08:54 PDT
Created attachment 264300 [details]
Proposed patch for all platforms except Windows X86
Need to work hands on to get Windows X86 working.
Comment on attachment 264300 [details] Proposed patch for all platforms except Windows X86 Attachment 264300 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/351761 New failing tests: js/regress-150663.html Created attachment 264301 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 264300 [details] Proposed patch for all platforms except Windows X86 Attachment 264300 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/351770 New failing tests: js/regress-150663.html Created attachment 264302 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 264300 [details] Proposed patch for all platforms except Windows X86 Attachment 264300 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/351760 New failing tests: js/regress-150663.html Created attachment 264303 [details]
Archive of layout-test-results from ews115 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 264300 [details]
Proposed patch for all platforms except Windows X86
EWS is angry.
Created attachment 264314 [details]
Patch with updated expectations for new test.
Forgot to update expected results after changing description() in prior patch.
Still need to implement Windows X86.
> Still need to implement Windows X86.
Will this patch start crashing the windows testers if it lands in its current state?
(In reply to comment #10) > > Still need to implement Windows X86. > > Will this patch start crashing the windows testers if it lands in its > current state? The new test should crash on Windows in the current state. I'm testing the Windows-86 specific part of the change now. I hope to post a new patch soon. Comment on attachment 264314 [details]
Patch with updated expectations for new test.
OK, let's not land this yet, since it would turn the windows testers red.
Created attachment 264355 [details]
Patch
Tested on Mac 32 & 64, iOS 32 & 64 and Win 32.
Comment on attachment 264355 [details]
Patch
r=me
Committed r191765: <http://trac.webkit.org/changeset/191765> The Windows X86-64 change was inadvertently missed when fixing this bug. That change is tracked in https://bugs.webkit.org/show_bug.cgi?id=150737 |