Summary: | Air::spillEverything() should try to replace tmps with spill slots without using registers whenever possible | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, ossy, saam, sam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 150279 | ||||||
Attachments: |
|
Description
Filip Pizlo
2015-10-28 18:56:30 PDT
Created attachment 264298 [details]
the patch
Attachment 264298 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/b3/air/AirSpillEverything.cpp:103: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 264298 [details]
the patch
r=me
Landed in http://trac.webkit.org/changeset/191742 (In reply to comment #4) > Landed in http://trac.webkit.org/changeset/191742 It broke the iOS build. (In reply to comment #5) > (In reply to comment #4) > > Landed in http://trac.webkit.org/changeset/191742 > > It broke the iOS build. I fixed it. (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Landed in http://trac.webkit.org/changeset/191742 > > > > It broke the iOS build. > > I fixed it. ... in https://trac.webkit.org/changeset/191750 Thanks for the fix. |