Bug 150625

Summary: Add WinCairo to list of ports in run-webkit-tests.
Product: WebKit Reporter: peavo
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, glenn, lforschler, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review+

peavo
Reported 2015-10-28 07:34:07 PDT
Instead of "reusing" the AppleWin port when running tests on WinCairo, we should add it as a port, and add baseline results for it.
Attachments
Patch (2.43 KB, patch)
2015-10-28 07:58 PDT, peavo 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2015-10-28 07:58:30 PDT
Created attachment 264212 [details] Patch
Brent Fulgham
Comment 2 2015-10-28 09:00:49 PDT
Comment on attachment 264212 [details] Patch I would suggest trying to share as much "Apple Windows" and "WinCairo" results as possible, though perhaps in practice there are too many differences in font handling, antialiasing, etc.
peavo
Comment 3 2015-10-28 10:18:41 PDT
(In reply to comment #2) > Comment on attachment 264212 [details] > Patch > Thanks for reviewing :) > I would suggest trying to share as much "Apple Windows" and "WinCairo" > results as possible, though perhaps in practice there are too many > differences in font handling, antialiasing, etc. Thanks, that makes sense :) I assume it means we have to change the fallback order? Currently, on Windows 10, I get the fallback order "wincairo-win10 -> wincairo -> mac -> generic".
Brent Fulgham
Comment 4 2015-10-28 10:28:10 PDT
(In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 264212 [details] > > Patch > > > > Thanks for reviewing :) > > > I would suggest trying to share as much "Apple Windows" and "WinCairo" > > results as possible, though perhaps in practice there are too many > > differences in font handling, antialiasing, etc. > > Thanks, that makes sense :) I assume it means we have to change the fallback > order? > Currently, on Windows 10, I get the fallback order "wincairo-win10 -> > wincairo -> mac -> generic". Yes -- I think we have fewer tests that are compatible with 'mac' now, since the font changes made in Yosemite mean even more things differ. So in practice, the 'mac' fallback may not be that useful anymore.
peavo
Comment 5 2015-10-28 10:35:12 PDT
Ok, thanks :) Btw, are you using the Times font from a Mac computer when you are running the layout tests on AppleWin? I ran some layout tests on AppleWin the other day, and I did not get the expected font metrics for the Times 16 font.
peavo
Comment 6 2015-10-28 10:53:09 PDT
Committed r191678: <http://trac.webkit.org/changeset/191678>.
Note You need to log in before you can comment on or make changes to this bug.