| Summary: | [EFL] Many layoutTests failed after r191623 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hunseop Jeong <hs85.jeong> | ||||
| Component: | WebKit EFL | Assignee: | Hunseop Jeong <hs85.jeong> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cgarcia, clopez, gyuyoung.kim, hyatt, lucas.de.marchi, ossy, zalan | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 149366 | ||||||
| Attachments: |
|
||||||
|
Description
Hunseop Jeong
2015-10-27 19:31:50 PDT
Created attachment 264202 [details]
WIP
I changed the expected results that was changed at r191623. I think we need more rebaseline work. (In reply to comment #2) > I changed the expected results that was changed at r191623. > I think we need more rebaseline work. I suggest you should land this huge patch in smaller pieces. Landing a huge patch can take ~ 10-20 minutes and probably it will fail due to conflict in LayoutTests/Changelog if somebody else landed a smaller patch touches the same changelog. cc-ing GTK guys too, you will need a similar patch. (In reply to comment #3) > (In reply to comment #2) > > I changed the expected results that was changed at r191623. > > I think we need more rebaseline work. > > I suggest you should land this huge patch in smaller pieces. > Landing a huge patch can take ~ 10-20 minutes and probably it will > fail due to conflict in LayoutTests/Changelog if somebody else landed > a smaller patch touches the same changelog. Okay, I will land it with smaller one. Rebaseline work - 1 Committed r191668: <http://trac.webkit.org/changeset/191668> Rebase line work - 2 Committed r191670: <http://trac.webkit.org/changeset/191670> Rebaseline work - last Committed r191681: <http://trac.webkit.org/changeset/191681> Rebaseline more tests Committed r191724: <http://trac.webkit.org/changeset/191724> |