Web Inspector: Show Timeline Markers again (DOMContentLoaded, Load, console.timeStamp)

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

* SUMMARY
Show Timeline Markers again (DOMContentLoaded, Load, console.timeStamp).

The markers were being received on the frontend, but nothing was happening with them. Show them again and update their styles.

[Radar WebKit Bug Importer]

<rdar://problem/23286592>

[Joseph Pecoraro]

Created attachment 264174 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 264175 [details]
[IMAGE] Markers

[Matt Baker]

Comment on attachment 264174 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=264174&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css:147
> +    opacity: 0.5;

I like the solid markers, but they visually compete with the record bars somewhat. Maybe an opacity of 0.2 would be better.

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css:152
> +    opacity: 0.5;

See above.

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css:157
> +    opacity: 0.5;

See above.

[Timothy Hatcher]

Comment on attachment 264174 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=264174&action=review

>> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css:147
>> +    opacity: 0.5;
> 
> I like the solid markers, but they visually compete with the record bars somewhat. Maybe an opacity of 0.2 would be better.

I agree, try 0.25.

[Matt Baker]

Comment on attachment 264174 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=264174&action=review

>>> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css:147
>>> +    opacity: 0.5;
>> 
>> I like the solid markers, but they visually compete with the record bars somewhat. Maybe an opacity of 0.2 would be better.
> 
> I agree, try 0.25.

Just applied the patch and 0.2 was too faint. 0.3 looked good. I also noticed the markers are above the timeline overview graph record bars in the z-order, but they are positioned behind record bars in the content view below. We want the current time marker to always be on top, but if we could resolve the z-index issue that would help visually.

[Matt Baker]

(In reply to comment #6)
> Comment on attachment 264174 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264174&action=review
> 
> >>> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css:147
> >>> +    opacity: 0.5;
> >> 
> >> I like the solid markers, but they visually compete with the record bars somewhat. Maybe an opacity of 0.2 would be better.
> > 
> > I agree, try 0.25.
> 
> Just applied the patch and 0.2 was too faint. 0.3 looked good. I also
> noticed the markers are above the timeline overview graph record bars in the
> z-order, but they are positioned behind record bars in the content view
> below. We want the current time marker to always be on top, but if we could
> resolve the z-index issue that would help visually.

If that wasn't clear, I mean that the markers are less distracting in the bottom view, where they are behind the record bars.

[Timothy Hatcher]

Yeah I think behind the record bars would be good too.

[BJ Burg]

Comment on attachment 264174 [details]
[PATCH] Proposed Fix

Clearing cq? since it needs some tweaks per discussion above.

[Joseph Pecoraro]

(In reply to comment #8)
> Yeah I think behind the record bars would be good too.

I was able to do this on the bottom, but not the top due to how timeline-ruler selection works. We should revisit this when we start making timeline bubbles selectable.

[Joseph Pecoraro]

Created attachment 264264 [details]
[PATCH] For Landing

[Joseph Pecoraro]

http://trac.webkit.org/changeset/191703