Bug 150611

Summary: [EFL] Add Shadow DOM feature
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi, ossy, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2015-10-27 16:27:38 PDT
When we just enable the shadow dom macro, all shadow dom tests are passed on EFL port. Let's enable it.
Attachments
Patch (5.37 KB, patch)
2015-10-27 16:29 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (2.42 KB, patch)
2015-10-28 06:55 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-10-27 16:29:59 PDT
Created attachment 264171 [details] Patch
Csaba Osztrogonác
Comment 2 2015-10-28 04:03:12 PDT
http://trac.webkit.org/changeset/189841 enabled it on Mac with the following comment: "The feature is enabled by default on Mac and iOS ports for testing and disabled by default elsewhere." https://lists.webkit.org/pipermail/webkit-dev/2015-September/027661.html So the Shadow DOM implementation isn't complete yet, I'm not sure if we should enable this not complete feature now.
Gyuyoung Kim
Comment 3 2015-10-28 06:55:50 PDT
Created attachment 264211 [details] Patch
Gyuyoung Kim
Comment 4 2015-10-28 06:56:20 PDT
(In reply to comment #2) > http://trac.webkit.org/changeset/189841 enabled it on Mac with the > following comment: "The feature is enabled by default on Mac and iOS > ports for testing and disabled by default elsewhere." > > https://lists.webkit.org/pipermail/webkit-dev/2015-September/027661.html > > So the Shadow DOM implementation isn't complete yet, I'm > not sure if we should enable this not complete feature now. I decided to enable the shadow dom API after reading Rniwa's post. https://www.webkit.org/blog/4096/introducing-shadow-dom-api/ However it seems I too hurry to enable it for our port. ok, how about just adding a cmake variable at the moment ? Personally I'm interested in this feature.
Gyuyoung Kim
Comment 5 2015-10-30 00:34:01 PDT
Ossy any comment ?
Csaba Osztrogonác
Comment 6 2015-10-30 03:05:08 PDT
(In reply to comment #5) > Ossy any comment ? Sorry, I missed it. r=me
WebKit Commit Bot
Comment 7 2015-10-30 03:51:54 PDT
Comment on attachment 264211 [details] Patch Clearing flags on attachment: 264211 Committed r191785: <http://trac.webkit.org/changeset/191785>
WebKit Commit Bot
Comment 8 2015-10-30 03:52:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.