Bug 150599

Summary:

Add a debug overlay with information about web process resource usage.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore Misc.

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, cmarcelo, commit-queue, kling, koivisto, rniwa

Priority:

Keywords:

Performance

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Draft for EWS	none
Screen shot of draft patch in action	none
Draft for EWS	buildbot: commit-queue-
Archive of layout-test-results from ews113 for mac-yosemite	none
Draft for EWS	none
Draft for EWS	buildbot: commit-queue-
Archive of layout-test-results from ews115 for mac-yosemite	none
Archive of layout-test-results from ews102 for mac-mavericks	none
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none
Draft for EWS	none
Patch	none

Andreas Kling

Reported 2015-10-27 12:21:46 PDT

I'm putting together a debug HUD overlay that reports information about memory and CPU usage in the web process.

Attachments
Draft for EWS (65.49 KB, patch) 2015-10-27 13:01 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Screen shot of draft patch in action (386.41 KB, image/png) 2015-10-27 13:03 PDT, Andreas Kling	no flags	Details
Draft for EWS (52.00 KB, patch) 2015-10-27 15:14 PDT, Andreas Kling	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews113 for mac-yosemite (322.22 KB, application/zip) 2015-10-27 16:11 PDT, Build Bot	no flags	Details
Draft for EWS (52.03 KB, patch) 2015-10-27 17:36 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Draft for EWS (52.08 KB, patch) 2015-10-27 18:09 PDT, Andreas Kling	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews115 for mac-yosemite (72.63 KB, application/zip) 2015-10-27 19:01 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-mavericks (99.00 KB, application/zip) 2015-10-27 19:07 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (273.64 KB, application/zip) 2015-10-27 19:31 PDT, Build Bot	no flags	Details
Draft for EWS (57.32 KB, patch) 2015-10-28 14:10 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Patch (71.18 KB, patch) 2015-10-30 15:04 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2015-10-27 13:01:22 PDT

Created attachment 264151 [details] Draft for EWS

Andreas Kling

Comment 2 2015-10-27 13:03:26 PDT

Created attachment 264152 [details] Screen shot of draft patch in action

Andreas Kling

Comment 3 2015-10-27 15:14:56 PDT

Created attachment 264165 [details] Draft for EWS Oh, rebased on ToT.

WebKit Commit Bot

Comment 4 2015-10-27 15:17:14 PDT

Attachment 264165 [details] did not pass style-queue: ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:62: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:40: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:46: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:147: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:160: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:167: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:320: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:355: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:457: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:492: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 13 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 5 2015-10-27 16:11:14 PDT

Comment on attachment 264165 [details] Draft for EWS Attachment 264165 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/346010 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2015-10-27 16:11:17 PDT

Created attachment 264170 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5

Andreas Kling

Comment 7 2015-10-27 17:36:04 PDT

Created attachment 264183 [details] Draft for EWS

WebKit Commit Bot

Comment 8 2015-10-27 17:38:47 PDT

Attachment 264183 [details] did not pass style-queue: ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:62: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:40: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:46: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:148: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:170: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:323: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:358: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:460: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:495: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 13 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 9 2015-10-27 18:09:28 PDT

Created attachment 264186 [details] Draft for EWS

WebKit Commit Bot

Comment 10 2015-10-27 18:11:58 PDT

Attachment 264186 [details] did not pass style-queue: ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:40: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:46: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:148: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:170: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:323: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:358: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:460: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:495: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 12 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 11 2015-10-27 19:01:15 PDT

Comment on attachment 264186 [details] Draft for EWS Attachment 264186 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/346534 Number of test failures exceeded the failure limit.

Build Bot

Comment 12 2015-10-27 19:01:17 PDT

Created attachment 264188 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 13 2015-10-27 19:07:16 PDT

Comment on attachment 264186 [details] Draft for EWS Attachment 264186 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/346542 Number of test failures exceeded the failure limit.

Build Bot

Comment 14 2015-10-27 19:07:18 PDT

Created attachment 264190 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 15 2015-10-27 19:31:49 PDT

Comment on attachment 264186 [details] Draft for EWS Attachment 264186 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/346611 Number of test failures exceeded the failure limit.

Build Bot

Comment 16 2015-10-27 19:31:51 PDT

Created attachment 264191 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Andreas Kling

Comment 17 2015-10-28 14:10:31 PDT

Created attachment 264241 [details] Draft for EWS Now with WebCore::Settings and WK2 SPI preferences hookups. Layout tests hopefully working again.

WebKit Commit Bot

Comment 18 2015-10-28 14:17:46 PDT

Attachment 264241 [details] did not pass style-queue: ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:43: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:49: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:151: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:154: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:173: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:326: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:361: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:463: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:498: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 13 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 19 2015-10-30 15:04:06 PDT

Created attachment 264426 [details] Patch

WebKit Commit Bot

Comment 20 2015-10-30 15:05:48 PDT

Attachment 264426 [details] did not pass style-queue: ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/PlatformMac.cmake:272: Alphabetical sorting problem. "page/cocoa/ResourceUsageOverlayCocoa.mm" should be before "page/cocoa/UserAgent.mm". [list/order] [5] Total errors found: 2 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 21 2015-10-31 19:30:38 PDT

Comment on attachment 264426 [details] Patch Clearing flags on attachment: 264426 Committed r191849: <http://trac.webkit.org/changeset/191849>

WebKit Commit Bot

Comment 22 2015-10-31 19:30:43 PDT

All reviewed patches have been landed. Closing bug.

Andreas Kling

Comment 23 2015-10-31 22:48:44 PDT

Committed r191851: <http://trac.webkit.org/changeset/191851>

Note You need to log in before you can comment on or make changes to this bug.