Bug 15058

Summary:

Precedence fault in KeyEventGdk causes shift, control, alt etc to work incorrectly

Product:

WebKit

Reporter:

Jasper Bryant-Greene <m>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Gtk

Priority:

Version:

523.x (Safari 3)

Hardware:

OS:

Linux

Attachments:

Description	Flags
correct precendence fault in KeyEventGdk	none
patch now includes ChangeLog entry	darin: review+

Jasper Bryant-Greene

Reported 2007-08-22 20:30:58 PDT

There's a precendence fault in KeyEventGdk which makes shift, control, alt and meta work very oddly. A patch is attached.

Attachments
correct precendence fault in KeyEventGdk (806 bytes, patch) 2007-08-22 20:31 PDT, Jasper Bryant-Greene	no flags	Details Formatted Diff Diff
patch now includes ChangeLog entry (1.36 KB, patch) 2007-08-22 20:37 PDT, Jasper Bryant-Greene	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jasper Bryant-Greene

Comment 1 2007-08-22 20:31:30 PDT

Created attachment 16084 [details] correct precendence fault in KeyEventGdk

Jasper Bryant-Greene

Comment 2 2007-08-22 20:37:39 PDT

Created attachment 16085 [details] patch now includes ChangeLog entry

Alp Toker

Comment 3 2007-10-22 06:24:17 PDT

Please mark any bug report patches "r?" for review, and also use the gtk tag or we won't notice them. Thanks!

Darin Adler

Comment 4 2007-10-23 07:20:17 PDT

Comment on attachment 16085 [details] patch now includes ChangeLog entry r=me

Alp Toker

Comment 5 2007-10-23 12:40:18 PDT

Fix landed in r26924. Thanks, sorry this took so long for us to notice.

Note You need to log in before you can comment on or make changes to this bug.