Bug 150575

Summary: [Win] LayoutTest js/intl-collator.html failing on Win 7
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, commit-queue, msaboff, sukolsak
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch none

Ryan Haddad
Reported 2015-10-26 15:13:09 PDT
ayoutTest js/intl-collator.html failing on Win 7 <https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r191594%20(54748)/results.html> --- /home/buildbot/slave/win-release-tests/build/layout-test-results/js/intl-collator-expected.txt +++ /home/buildbot/slave/win-release-tests/build/layout-test-results/js/intl-collator-actual.txt @@ -30,7 +30,7 @@ PASS testCollator(Intl.Collator('en-u-co-standard'), [{locale: 'en'}]) is true PASS testCollator(Intl.Collator('en-u-co-search'), [{locale: 'en'}]) is true PASS testCollator(Intl.Collator('en-u-co-abcd'), [{locale: 'en'}]) is true -PASS testCollator(Intl.Collator('de-u-co-phonebk'), [{locale: 'de-u-co-phonebk', collation: 'phonebk'}]) is true +FAIL testCollator(Intl.Collator('de-u-co-phonebk'), [{locale: 'de-u-co-phonebk', collation: 'phonebk'}]) should be true. Was false. PASS testCollator(Intl.Collator('en-u-kn'), [{locale: 'en', numeric: true}]) is true PASS testCollator(Intl.Collator('en-u-kn-true'), [{locale: 'en-u-kn-true', numeric: true}]) is true PASS testCollator(Intl.Collator('en-u-kn-false'), [{locale: 'en-u-kn-false', numeric: false}]) is true
Attachments
Patch (1.76 KB, patch)
2015-10-26 16:55 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Patch (2.93 KB, patch)
2015-10-26 17:00 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sukolsak Sakshuwong
Comment 1 2015-10-26 16:50:36 PDT
It seems that ICU on Windows 7 doesn't support the German phonebook collation.
Sukolsak Sakshuwong
Comment 2 2015-10-26 16:55:19 PDT
Created attachment 264099 [details] Patch
Sukolsak Sakshuwong
Comment 3 2015-10-26 17:00:22 PDT
Created attachment 264100 [details] Patch
Alexey Proskuryakov
Comment 4 2015-10-27 20:28:53 PDT
Comment on attachment 264100 [details] Patch Longer term, we should probably update ICU.
WebKit Commit Bot
Comment 5 2015-10-28 04:14:39 PDT
Comment on attachment 264100 [details] Patch Clearing flags on attachment: 264100 Committed r191664: <http://trac.webkit.org/changeset/191664>
WebKit Commit Bot
Comment 6 2015-10-28 04:14:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.