Bug 150573

Summary:

Web Inspector: Spacebar to start recording should not cause system beep

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, simon.fraser, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-10-26 14:27:32 PDT

* SUMMARY
Spacebar to start recording should not cause system beep.

* STEPS TO REPRODUCE
1. Open inspector
2. Show Timeline tab
3. Click "Spacebar" to start a recording
  => System Beep, as if nothing happened. Expected no beep, since it worked.

Comment 1 Joseph Pecoraro 2015-10-26 14:28:45 PDT

Created attachment 264076 [details]
[PATCH] Proposed Fix

Comment 2 WebKit Commit Bot 2015-10-26 17:09:08 PDT

Comment on attachment 264076 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 264076

Committed r191613: <http://trac.webkit.org/changeset/191613>

Comment 3 WebKit Commit Bot 2015-10-26 17:09:11 PDT

All reviewed patches have been landed.  Closing bug.