Summary: | Builtins generator should put WebCore-only wrappers in the per-builtin header | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
Component: | Tools / Tests | Assignee: | BJ Burg <bburg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, lforschler, youennf, ysuzuki | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 150496 | ||||||||
Attachments: |
|
Description
BJ Burg
2015-10-24 16:52:46 PDT
Created attachment 263989 [details]
Proposed Fix
Attachment 263989 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_header.py:71: [BuiltinsSeparateHeaderGenerator.generate_output] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member [pylint/E1101] [5]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 263991 [details]
Proposed Fix
Attachment 263991 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_header.py:71: [BuiltinsSeparateHeaderGenerator.generate_output] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member [pylint/E1101] [5]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 263991 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=263991&action=review Thanks for moving that forward. Obviously, I like it. > Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_header.py:86 > + ("WebCore", "%sBuiltins.h" % self.object.object_name), We probably do not need that include. > Source/JavaScriptCore/Scripts/builtins/builtins_templates.py:138 > """class ${objectName}BuiltinsWrapper : private JSC::WeakHandleOwner { ${objectName}BuiltinsWrapper could be renamed ${objectName}Builtins later on. Hopefully, only Source/WebCore/bindings/js/WebCoreJSBuiltins.h and WebCoreJSBuiltinInternals.h should need to be updated. We might also want to clean a little bit ${objectName}BuiltinFunctions in the future. Comment on attachment 263991 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=263991&action=review >> Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_header.py:86 >> + ("WebCore", "%sBuiltins.h" % self.object.object_name), > > We probably do not need that include. OK. >> Source/JavaScriptCore/Scripts/builtins/builtins_templates.py:138 >> """class ${objectName}BuiltinsWrapper : private JSC::WeakHandleOwner { > > ${objectName}BuiltinsWrapper could be renamed ${objectName}Builtins later on. > Hopefully, only Source/WebCore/bindings/js/WebCoreJSBuiltins.h and WebCoreJSBuiltinInternals.h should need to be updated. > > We might also want to clean a little bit ${objectName}BuiltinFunctions in the future. Sure, this can be a followup. Youenn, can you review this patch? I don't want it to get stale. Committed r191842: <http://trac.webkit.org/changeset/191842> |