Summary: | StoreOpLoad pattern matching should check effects between the Store and Load | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 150279 | ||||||||
Attachments: |
|
Description
Filip Pizlo
2015-10-24 12:39:31 PDT
Created attachment 264339 [details]
the patch
Attachment 264339 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/b3/testb3.cpp:390: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:391: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2]
Total errors found: 2 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264340 [details]
the patch
Attachment 264340 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/b3/testb3.cpp:390: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:391: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2]
Total errors found: 2 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 264340 [details]
the patch
r=me
Landed in http://trac.webkit.org/changeset/191762 |