Bug 150500

Summary: [GTK][Mac] disable OBJC JSC API
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: JavaScriptCoreAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126492    
Attachments:
Description Flags
Patch
none
Patch none

Description Philippe Normand 2015-10-23 08:11:03 PDT 
The Mac flavour of the GTK port can't really support this it seems.
Comment 1 Philippe Normand 2015-10-23 08:13:43 PDT 
Created attachment 263925 [details]
Patch
Comment 2 Philippe Normand 2015-10-23 08:51:33 PDT 
Created attachment 263927 [details]
Patch
Comment 3 Philippe Normand 2015-10-23 08:53:21 PDT 
Comment on attachment 263927 [details]
Patch

oops
Comment 4 Alex Christensen 2015-10-29 20:38:32 PDT 
Comment on attachment 263925 [details]
Patch

Sure, why not.
Comment 5 WebKit Commit Bot 2015-10-29 21:31:15 PDT 
Comment on attachment 263925 [details]
Patch

Clearing flags on attachment: 263925

Committed r191775: <http://trac.webkit.org/changeset/191775>
Comment 6 WebKit Commit Bot 2015-10-29 21:31:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Alex Christensen 2015-10-29 23:15:50 PDT 
(In reply to comment #4)
> Comment on attachment 263925 [details]
> Patch
> 
> Sure, why not.
Just so nobody thinks I'm carelessly throwing things into the API, I am aware that this will break compiling any third party applications that use the JSC ObjC API and have BUILDING_GTK__ defined for some reason.  I think that's worth having, though, to support GTK development.

Why can't GTK on Mac support this, though?
Comment 8 Philippe Normand 2015-10-30 01:21:26 PDT 
(In reply to comment #7)
> (In reply to comment #4)
> > Comment on attachment 263925 [details]
> > Patch
> > 
> > Sure, why not.
> Just so nobody thinks I'm carelessly throwing things into the API, I am
> aware that this will break compiling any third party applications that use
> the JSC ObjC API and have BUILDING_GTK__ defined for some reason.  I think
> that's worth having, though, to support GTK development.
> 
> Why can't GTK on Mac support this, though?

I suppose it would be possible to support. All I want for now is a basic build of GTK for Mac. If more people are interested we enable the OBJC API later on.