Summary: | [GTK][Mac] disable OBJC JSC API | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
Component: | JavaScriptCore | Assignee: | Philippe Normand <pnormand> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 126492 | ||||||||
Attachments: |
|
Description
Philippe Normand
2015-10-23 08:11:03 PDT
Created attachment 263925 [details]
Patch
Created attachment 263927 [details]
Patch
Comment on attachment 263927 [details]
Patch
oops
Comment on attachment 263925 [details]
Patch
Sure, why not.
Comment on attachment 263925 [details] Patch Clearing flags on attachment: 263925 Committed r191775: <http://trac.webkit.org/changeset/191775> All reviewed patches have been landed. Closing bug. (In reply to comment #4) > Comment on attachment 263925 [details] > Patch > > Sure, why not. Just so nobody thinks I'm carelessly throwing things into the API, I am aware that this will break compiling any third party applications that use the JSC ObjC API and have BUILDING_GTK__ defined for some reason. I think that's worth having, though, to support GTK development. Why can't GTK on Mac support this, though? (In reply to comment #7) > (In reply to comment #4) > > Comment on attachment 263925 [details] > > Patch > > > > Sure, why not. > Just so nobody thinks I'm carelessly throwing things into the API, I am > aware that this will break compiling any third party applications that use > the JSC ObjC API and have BUILDING_GTK__ defined for some reason. I think > that's worth having, though, to support GTK development. > > Why can't GTK on Mac support this, though? I suppose it would be possible to support. All I want for now is a basic build of GTK for Mac. If more people are interested we enable the OBJC API later on. |