Bug 150484

Summary: Add an option to output the results of the graphics benchmark in JSON format
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: AnimationsAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, rniwa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Said Abou-Hallawa
Reported 2015-10-22 18:35:48 PDT
This will allow storing the results of the graphics benchmark. It can also be useful when reporting a bug or evaluating a new layout/rendering enhancement.
Attachments
Patch (39.99 KB, patch)
2015-10-23 19:32 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (40.24 KB, patch)
2015-10-26 08:49 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-10-23 16:06:11 PDT
<rdar://problem/23243721>
Said Abou-Hallawa
Comment 2 2015-10-23 19:32:11 PDT
Created attachment 263975 [details] Patch
Ryosuke Niwa
Comment 3 2015-10-23 22:03:44 PDT
Is the JSON format compatible with run-benchmark script? If not, we should make it compatible
Darin Adler
Comment 4 2015-10-24 15:56:38 PDT
Comment on attachment 263975 [details] Patch Just a rubber stamp, but rs=me
Said Abou-Hallawa
Comment 5 2015-10-26 08:49:55 PDT
Created attachment 264044 [details] Patch
Said Abou-Hallawa
Comment 6 2015-10-26 08:56:43 PDT
(In reply to comment #3) > Is the JSON format compatible with run-benchmark script? > > If not, we should make it compatible The JSON includes detailed info such as the frame rate sampled points which can be used only for for debugging purposes. But I will update the patch of https://bugs.webkit.org/show_bug.cgi?id=150450 to match the JSON format as closely as possible.
WebKit Commit Bot
Comment 7 2015-10-26 09:45:40 PDT
Comment on attachment 264044 [details] Patch Clearing flags on attachment: 264044 Committed r191586: <http://trac.webkit.org/changeset/191586>
WebKit Commit Bot
Comment 8 2015-10-26 09:45:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.