Bug 150453

Summary: We don't properly optimize TDZ checks when we declare a let variable without an initializer
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Saam Barati
Reported 2015-10-22 10:56:46 PDT
i.e: ``` let v; return v; ``` has a TDZ check on the return value. But, if we do: ``` let v = 20; return v; ``` we optimize out the TDZ check.
Attachments
Patch (1.36 KB, patch)
2016-03-29 12:45 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-03-26 11:53:24 PDT
This is probably a one line patch. I'm going to do it soon
Saam Barati
Comment 2 2016-03-29 12:45:57 PDT
Created attachment 275121 [details] Patch
Mark Lam
Comment 3 2016-03-29 12:54:08 PDT
Comment on attachment 275121 [details] Patch r=me
WebKit Commit Bot
Comment 4 2016-03-29 15:11:23 PDT
Comment on attachment 275121 [details] Patch Clearing flags on attachment: 275121 Committed r198803: <http://trac.webkit.org/changeset/198803>
WebKit Commit Bot
Comment 5 2016-03-29 15:11:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.