Bug 150430

Summary:

Air needs syntax for escaping StackSlots

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

150279

Attachments:

Description	Flags
the patch	ggaren: review+

Description Filip Pizlo 2015-10-21 18:19:31 PDT

It'll need it because otherwise we won't be able to select instructions for the StackSlot Value except if it's always used by Load/Store.

Comment 1 Filip Pizlo 2015-10-29 11:46:30 PDT

Created attachment 264328 [details]
the patch

Comment 2 WebKit Commit Bot 2015-10-29 11:50:14 PDT

Attachment 264328 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/air/AirAllocateStack.cpp:112:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Geoffrey Garen 2015-10-29 11:50:53 PDT

Comment on attachment 264328 [details]
the patch

r=me

Comment 4 Filip Pizlo 2015-10-29 12:04:19 PDT

Hmmm, EWS is taking a long time.  I'll wait a bit before landing.

Comment 5 Filip Pizlo 2015-10-29 12:17:42 PDT

Landed in http://trac.webkit.org/changeset/191745