Bug 15043

Summary: KJS::allocateBlock(): posix_memalign takes a void** as its first parameter
Product: WebKit Reporter: Ryan Leavengood <leavengood>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Fix to posix_memalign call in KJS::allocateBlock
none
The same patch, with the removal of the reinterpret_cast in the memset call mjs: review+

Ryan Leavengood
Reported 2007-08-21 17:33:04 PDT
This clearly is not code that any current port uses, since it should not compile without the change attached. But my port makes use of this since it was already in the code, instead of making another #elsif. But as shown by the documentation here: http://www.opengroup.org/onlinepubs/000095399/functions/posix_memalign.html the function is being called incorrectly. The simple patch attached corrects that.
Attachments
Fix to posix_memalign call in KJS::allocateBlock (1.18 KB, patch)
2007-08-21 17:35 PDT, Ryan Leavengood 		no flags
DetailsFormatted DiffDiff
The same patch, with the removal of the reinterpret_cast in the memset call (1.22 KB, patch)
2007-08-21 18:28 PDT, Ryan Leavengood 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryan Leavengood
Comment 1 2007-08-21 17:35:04 PDT
Created attachment 16066 [details] Fix to posix_memalign call in KJS::allocateBlock
Darin Adler
Comment 2 2007-08-21 17:38:53 PDT
Comment on attachment 16066 [details] Fix to posix_memalign call in KJS::allocateBlock I also don't think the reinterpret_cast is needed on the next line.
Ryan Leavengood
Comment 3 2007-08-21 17:45:36 PDT
Would you like me to make that change and create another patch, or could you take care of it? :)
Ryan Leavengood
Comment 4 2007-08-21 18:28:52 PDT
Created attachment 16067 [details] The same patch, with the removal of the reinterpret_cast in the memset call
David Kilzer (:ddkilzer)
Comment 5 2007-08-21 21:46:35 PDT
(In reply to comment #0) > This clearly is not code that any current port uses, since it should not > compile without the change attached. But my port makes use of this since it was > already in the code, instead of making another #elsif. [...] What port are you working on? :)
Ryan Leavengood
Comment 6 2007-08-22 06:22:52 PDT
(In reply to comment #5) > > What port are you working on? :) I am porting WebKit to Haiku, http://haiku-os.org. It is a clone of BeOS.
Maciej Stachowiak
Comment 7 2007-08-28 21:17:07 PDT
Comment on attachment 16067 [details] The same patch, with the removal of the reinterpret_cast in the memset call r=me Probably other ports could use memalign too, but don't set the right ifdef so they get the generic mmap-based version.
Mark Rowe (bdash)
Comment 8 2007-08-29 10:41:53 PDT
Landed in r25296.
Note You need to log in before you can comment on or make changes to this bug.