Summary: | KJS::allocateBlock(): posix_memalign takes a void** as its first parameter | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Leavengood <leavengood> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Minor | ||||||||
Priority: | P2 | ||||||||
Version: | 523.x (Safari 3) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Ryan Leavengood
2007-08-21 17:33:04 PDT
Created attachment 16066 [details]
Fix to posix_memalign call in KJS::allocateBlock
Comment on attachment 16066 [details]
Fix to posix_memalign call in KJS::allocateBlock
I also don't think the reinterpret_cast is needed on the next line.
Would you like me to make that change and create another patch, or could you take care of it? :) Created attachment 16067 [details]
The same patch, with the removal of the reinterpret_cast in the memset call
(In reply to comment #0) > This clearly is not code that any current port uses, since it should not > compile without the change attached. But my port makes use of this since it was > already in the code, instead of making another #elsif. [...] What port are you working on? :) (In reply to comment #5) > > What port are you working on? :) I am porting WebKit to Haiku, http://haiku-os.org. It is a clone of BeOS. Comment on attachment 16067 [details]
The same patch, with the removal of the reinterpret_cast in the memset call
r=me
Probably other ports could use memalign too, but don't set the right ifdef so they get the generic mmap-based version.
|