Summary: | Get rid of useBinaryEncoding from WKPageGetContentsAsMHTMLData | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Anders Carlsson
2015-10-21 14:33:51 PDT
Created attachment 263742 [details]
Patch
Attachment 263742 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2642: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:755: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 263743 [details]
Patch
Attachment 263743 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2642: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:755: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 263743 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263743&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:-2530 > - ? MHTMLArchive::generateMHTMLDataUsingBinaryEncoding(m_page.get()) If you're doing this, why not go further and remove generateMHTMLDataUsingBinaryEncoding from MHTMLArchive.h and cpp? Comment on attachment 263743 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263743&action=review >> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:-2530 >> - ? MHTMLArchive::generateMHTMLDataUsingBinaryEncoding(m_page.get()) > > If you're doing this, why not go further and remove generateMHTMLDataUsingBinaryEncoding from MHTMLArchive.h and cpp? Yeah, it doesn't look like there are other callers. (In reply to comment #6) > Comment on attachment 263743 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=263743&action=review > > >> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:-2530 > >> - ? MHTMLArchive::generateMHTMLDataUsingBinaryEncoding(m_page.get()) > > > > If you're doing this, why not go further and remove generateMHTMLDataUsingBinaryEncoding from MHTMLArchive.h and cpp? > > Yeah, it doesn't look like there are other callers. Going to do that in a follow-up patch! Committed r191408: <http://trac.webkit.org/changeset/191408> |