| Summary: | Print out the render tree from command line. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, honglh, kondapallykalyan, ossy, sam, simon.fraser, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 150441 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2015-10-21 14:28:05 PDT
Created attachment 263740 [details]
Patch
Comment on attachment 263740 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263740&action=review > Source/WebCore/platform/Logging.cpp:32 > +#if PLATFORM(COCOA) Space above this I think. > Source/WebCore/rendering/RenderObject.cpp:82 > +#if PLATFORM(COCOA) > +#include <notify.h> > +#endif Don't need this here. Comment on attachment 263740 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263740&action=review > Source/WebCore/ChangeLog:7 > + to print out the rendere tree for the live documents. rendere! > Source/WebCore/rendering/RenderObject.cpp:2236 > + fprintf(stderr, "----------------------mainframe--------------------------\n"); main frame? Created attachment 263789 [details]
Patch
Comment on attachment 263789 [details] Patch Clearing flags on attachment: 263789 Committed r191439: <http://trac.webkit.org/changeset/191439> All reviewed patches have been landed. Closing bug. When I am building debug mode, the build failed ../../lib/libWPEWebKit.so.0.0.1: error: undefined reference to 'WebCore::Frame::isMainFrame() const' Since Frame::isMainFrame() is inline function defined in MainFrame.h, The change made here introduce reference to isMainFrame without using #include "MainFrame.h" Is that the cause of above build failure? |