Summary: | [iOS] Allow clients to specify a custom input view to be used for a form input session | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||
Component: | WebKit2 | Assignee: | mitz | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, dbates, thorton, wenson_hsieh | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
mitz
2015-10-21 10:00:14 PDT
Created attachment 263691 [details]
Add customInputView property to _WKFormInputSession
Comment on attachment 263691 [details] Add customInputView property to _WKFormInputSession View in context: https://bugs.webkit.org/attachment.cgi?id=263691&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:236 > + RetainPtr<UIView> _customInputView; Adding the WKFocusedElementInfo here would help third-party clients determine what custom view they want to show, since they won't have access to userObject when (if) we make this public. (In reply to comment #2) > Comment on attachment 263691 [details] > Add customInputView property to _WKFormInputSession > > View in context: > https://bugs.webkit.org/attachment.cgi?id=263691&action=review > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:236 > > + RetainPtr<UIView> _customInputView; > > Adding the WKFocusedElementInfo here would help third-party clients > determine what custom view they want to show, since they won't have access > to userObject when (if) we make this public. Agreed! I should do that in a separate patch. (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 263691 [details] > > Add customInputView property to _WKFormInputSession > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=263691&action=review > > > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:236 > > > + RetainPtr<UIView> _customInputView; > > > > Adding the WKFocusedElementInfo here would help third-party clients > > determine what custom view they want to show, since they won't have access > > to userObject when (if) we make this public. > > Agreed! I should do that in a separate patch. See bug 150512. Committed <http://trac.webkit.org/r191534>. |