Bug 150395

Summary: [iOS] Allow clients to specify a custom input view to be used for a form input session
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, dbates, thorton, wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add customInputView property to _WKFormInputSession thorton: review+

mitz
Reported 2015-10-21 10:00:14 PDT
[iOS] Allow clients to specify a custom input view to be used for a form input session
Attachments
Add customInputView property to _WKFormInputSession (2.82 KB, patch)
2015-10-21 10:02 PDT, mitz 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2015-10-21 10:02:24 PDT
Created attachment 263691 [details] Add customInputView property to _WKFormInputSession
Wenson Hsieh
Comment 2 2015-10-21 10:24:58 PDT
Comment on attachment 263691 [details] Add customInputView property to _WKFormInputSession View in context: https://bugs.webkit.org/attachment.cgi?id=263691&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:236 > + RetainPtr<UIView> _customInputView; Adding the WKFocusedElementInfo here would help third-party clients determine what custom view they want to show, since they won't have access to userObject when (if) we make this public.
mitz
Comment 3 2015-10-21 10:42:42 PDT
(In reply to comment #2) > Comment on attachment 263691 [details] > Add customInputView property to _WKFormInputSession > > View in context: > https://bugs.webkit.org/attachment.cgi?id=263691&action=review > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:236 > > + RetainPtr<UIView> _customInputView; > > Adding the WKFocusedElementInfo here would help third-party clients > determine what custom view they want to show, since they won't have access > to userObject when (if) we make this public. Agreed! I should do that in a separate patch.
mitz
Comment 4 2015-10-23 13:40:51 PDT
(In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 263691 [details] > > Add customInputView property to _WKFormInputSession > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=263691&action=review > > > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:236 > > > + RetainPtr<UIView> _customInputView; > > > > Adding the WKFocusedElementInfo here would help third-party clients > > determine what custom view they want to show, since they won't have access > > to userObject when (if) we make this public. > > Agreed! I should do that in a separate patch. See bug 150512.
mitz
Comment 5 2015-10-24 08:55:01 PDT
Committed <http://trac.webkit.org/r191534>.
Note You need to log in before you can comment on or make changes to this bug.