Bug 150361

Summary: [UNIX] ASSERTION FAILED: m_shouldWaitForSyncReplies in Connection::connectionDidClose()
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, gns, mrobinson
Priority: P2 Keywords: Gtk, LayoutTestFailure
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mrobinson: review+

Description Carlos Garcia Campos 2015-10-20 05:51:21 PDT
This happens sometimes with several layout tests and unit tests in the GTK+ port. It doesn't always happen because it depends on how sockets are closed, and the state of the threads. The problem is that we are not handling the case when the read fails because we closed the connection. In that case we log the error and call Connection::connectionDidClose(). But it was connection didClose() the one closing the socket. So, in this particular case is not an error but a normal termination, and we shouldn't try to close the connection again. Something similar can happen while sending a message, and we get a broken pipe error, but in that case we are only showing the error, so it's harmless.

04:43:46.949 29374   Error receiving IPC message on socket -1 in process 12732: Bad file descriptor
04:43:46.949 29374   ASSERTION FAILED: m_shouldWaitForSyncReplies
04:43:46.949 29374   ../../Source/WebKit2/Platform/IPC/Connection.cpp(766) : void IPC::Connection::connectionDidClose()
04:43:46.950 29374   1   0x2b0713765a83 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x2b0713765a83]
04:43:46.950 29374   2   0x2b070bb1e1e7 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN3IPC10Connection18connectionDidCloseEv+0x7d) [0x2b070bb1e1e7]
04:43:46.950 29374   3   0x2b070bf4713c /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN3IPC10Connection16readyReadHandlerEv+0x11e) [0x2b070bf4713c]
04:43:46.950 29374   4   0x2b070bf47296 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x4cb0296) [0x2b070bf47296]
04:43:46.950 29374   5   0x2b070bf4852e /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x4cb152e) [0x2b070bf4852e]
04:43:46.950 29374   6   0x2b070ba988be /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNKSt8functionIFvvEEclEv+0x32) [0x2b070ba988be]
04:43:46.950 29374   7   0x2b07137b964d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(_ZN3WTF15GMainLoopSource12voidCallbackEv+0x6d) [0x2b07137b964d]
04:43:46.950 29374   8   0x2b07137b9d51 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(_ZN3WTF15GMainLoopSource18voidSourceCallbackEPS0_+0x23) [0x2b07137b9d51]
04:43:46.950 29374   9   0x2b07168343a5 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(+0x563a5) [0x2b07168343a5]
04:43:46.950 29374   10  0x2b0716831a26 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(+0x53a26) [0x2b0716831a26]
04:43:46.950 29374   11  0x2b0716832854 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(g_main_context_dispatch+0x33) [0x2b0716832854]
04:43:46.950 29374   12  0x2b0716832a39 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(+0x54a39) [0x2b0716832a39]
04:43:46.950 29374   13  0x2b0716832e60 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(g_main_loop_run+0x1d7) [0x2b0716832e60]
04:43:46.950 29374   14  0x2b07137bd4d2 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x18324d2) [0x2b07137bd4d2]
04:43:46.950 29374   15  0x2b07137be213 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x1833213) [0x2b07137be213]
04:43:46.950 29374   16  0x2b070ba988be /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNKSt8functionIFvvEEclEv+0x32) [0x2b070ba988be]
04:43:46.950 29374   17  0x2b0713780aa0 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x17f5aa0) [0x2b0713780aa0]
04:43:46.950 29374   18  0x2b07137b4384 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x1829384) [0x2b07137b4384]
04:43:46.950 29374   19  0x2b07149df0a4 /lib/x86_64-linux-gnu/libpthread.so.0(+0x80a4) [0x2b07149df0a4]
04:43:46.950 29374   20  0x2b071a6df04d /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x2b071a6df04d]
04:43:46.950 29374   1   0x2b682a669a83 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x2b682a669a83]
04:43:46.950 29374   2   0x2b6822a221e7 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN3IPC10Connection18connectionDidCloseEv+0x7d) [0x2b6822a221e7]
04:43:46.950 29374   3   0x2b6822e4b13c /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN3IPC10Connection16readyReadHandlerEv+0x11e) [0x2b6822e4b13c]
04:43:46.950 29374   4   0x2b6822e4b296 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x4cb0296) [0x2b6822e4b296]
04:43:46.950 29374   5   0x2b6822e4c52e /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x4cb152e) [0x2b6822e4c52e]
04:43:46.950 29374   6   0x2b682299c8be /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNKSt8functionIFvvEEclEv+0x32) [0x2b682299c8be]
04:43:46.950 29374   7   0x2b682a6bd64d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(_ZN3WTF15GMainLoopSource12voidCallbackEv+0x6d) [0x2b682a6bd64d]
04:43:46.950 29374   8   0x2b682a6bdd51 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(_ZN3WTF15GMainLoopSource18voidSourceCallbackEPS0_+0x23) [0x2b682a6bdd51]
04:43:46.950 29374   9   0x2b682d7383a5 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(+0x563a5) [0x2b682d7383a5]
04:43:46.950 29374   10  0x2b682d735a26 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(+0x53a26) [0x2b682d735a26]
04:43:46.950 29374   11  0x2b682d736854 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(g_main_context_dispatch+0x33) [0x2b682d736854]
04:43:46.950 29374   12  0x2b682d736a39 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(+0x54a39) [0x2b682d736a39]
04:43:46.950 29374   13  0x2b682d736e60 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(g_main_loop_run+0x1d7) [0x2b682d736e60]
04:43:46.950 29374   14  0x2b682a6c14d2 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x18324d2) [0x2b682a6c14d2]
04:43:46.950 29374   15  0x2b682a6c2213 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x1833213) [0x2b682a6c2213]
04:43:46.950 29374   16  0x2b682299c8be /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNKSt8functionIFvvEEclEv+0x32) [0x2b682299c8be]
04:43:46.950 29374   17  0x2b682a684aa0 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x17f5aa0) [0x2b682a684aa0]
04:43:46.950 29374   18  0x2b682a6b8384 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x1829384) [0x2b682a6b8384]
04:43:46.950 29374   19  0x2b682b8e30a4 /lib/x86_64-linux-gnu/libpthread.so.0(+0x80a4) [0x2b682b8e30a4]
04:43:46.950 29374   20  0x2b68315e304d /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x2b68315e304d]
Comment 1 Carlos Garcia Campos 2015-10-20 05:55:17 PDT
Created attachment 263575 [details]
Patch
Comment 2 Carlos Garcia Campos 2015-10-20 08:05:31 PDT
Committed r191341: <http://trac.webkit.org/changeset/191341>