Bug 150343

Summary: Make sure development Safari does not delete the stable Safari cache storage.
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Severity: Normal CC: cgarcia, commit-queue, koivisto
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Chris Dumez 2015-10-19 14:58:34 PDT
Make sure development WebKit does not delete the stable WebKit cache storage. Development Safari now uses Version 5, while the last stable Safari uses Version 4. Since the 2 versions can co-exist, it is best not to drop the old cache version (4) at this point.
Comment 1 Chris Dumez 2015-10-19 15:02:22 PDT
Created attachment 263516 [details]
Comment 2 Antti Koivisto 2015-10-19 15:24:59 PDT
Comment on attachment 263516 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=263516&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:1028
> +            const unsigned preservedOldVersion = 4;

Might be good to add a comment explaining this. Also we might want to make this PLATFORM(MAC) as this is not useful at least on iOS.
Comment 3 Chris Dumez 2015-10-19 16:14:34 PDT
Created attachment 263523 [details]
Comment 4 WebKit Commit Bot 2015-10-19 17:02:19 PDT
Comment on attachment 263523 [details]

Clearing flags on attachment: 263523

Committed r191321: <http://trac.webkit.org/changeset/191321>
Comment 5 WebKit Commit Bot 2015-10-19 17:02:26 PDT
All reviewed patches have been landed.  Closing bug.