Bug 150343

Summary: Make sure development Safari does not delete the stable Safari cache storage.
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, koivisto
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2015-10-19 14:58:34 PDT
Make sure development WebKit does not delete the stable WebKit cache storage. Development Safari now uses Version 5, while the last stable Safari uses Version 4. Since the 2 versions can co-exist, it is best not to drop the old cache version (4) at this point.
Attachments
Patch (1.83 KB, patch)
2015-10-19 15:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.98 KB, patch)
2015-10-19 16:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-10-19 15:02:22 PDT
Created attachment 263516 [details] Patch
Antti Koivisto
Comment 2 2015-10-19 15:24:59 PDT
Comment on attachment 263516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263516&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:1028 > + const unsigned preservedOldVersion = 4; Might be good to add a comment explaining this. Also we might want to make this PLATFORM(MAC) as this is not useful at least on iOS.
Chris Dumez
Comment 3 2015-10-19 16:14:34 PDT
Created attachment 263523 [details] Patch
WebKit Commit Bot
Comment 4 2015-10-19 17:02:19 PDT
Comment on attachment 263523 [details] Patch Clearing flags on attachment: 263523 Committed r191321: <http://trac.webkit.org/changeset/191321>
WebKit Commit Bot
Comment 5 2015-10-19 17:02:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.