Bug 150312 – Add ouput formatters for FillLayer and all it entails

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Add ouput formatters for FillLayer and all it entails

[Simon Fraser (smfr)]

Created attachment 263440 [details]
Patch

[Simon Fraser (smfr)]

Sample output:

(fill-layer
  (x-position [0%])
  (y-position [50%])
  (size-length width=[25%] height=[100%])
  (size-type size-length)
  (size type=size-length size=width=[25%] height=[100%])
  (background-origin left top)
  (repeat no-repeat no-repeat)
  (clip border)
  (origin padding)
  (composite 2)
  (blend-mode normal)
  (mask-type alpha)
  (fill-layer
    (x-position [100%])
    (y-position [50%])
    (size-length width=[45%] height=[100%])
    (size-type size-none)
    (size type=size-none size=width=[45%] height=[100%])
    (background-origin left top)
    (repeat no-repeat no-repeat)
    (clip border)
    (origin padding)
    (composite 2)
    (blend-mode normal)
    (mask-type alpha)))

I'm open to better Length formatting.

[Tim Horton]

Two formatting questions:

(In reply to comment #2)
> Sample output:
> 
> (fill-layer
>   (x-position [0%])

What are the square brackets for? (Might be able to find out by reading the patch, but I haven't yet).

>   (size-length width=[25%] height=[100%])
>   (size-type size-length)
>   (size type=size-length size=width=[25%] height=[100%])

Why all three? It seems like the one with the 'size' key matches the other two. Also, the equal signs? This should probably read like below, no?

>   (size
>     (type length)
>     (width [25%])
>     (height [100%]))

[Simon Fraser (smfr)]

Created attachment 263500 [details]
Patch

[Simon Fraser (smfr)]

Output is now:

(fill-layer
  (position 0% 50%)
  (size size-length 25% 100%)
  (background-origin left top)
  (repeat no-repeat no-repeat)
  (clip border)
  (origin padding)
  (composite source-over)
  (blend-mode screen)
  (mask-type alpha)
  (fill-layer
    (position 100% 50%)
    (size size-none 45% 100%)
    (background-origin left top)
    (repeat no-repeat no-repeat)
    (clip border)
    (origin padding)
    (composite source-over)
    (blend-mode screen)
    (mask-type alpha)))

[Ryan Haddad]

Simon is already investigating, but this caused 13 tests to crash in debug with ASSERTION FAILED: blendOp < numBlendOperatorNames

[Simon Fraser (smfr)]

Fixed in https://trac.webkit.org/r191319

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/191310