Bug 150307

Summary:

[Win] Can't run MiniBrowser on Visual Studio after webkit.org/b/150124

Product:

WebKit

Reporter:

Sungmann Cho <sungmann.cho>

Component:

WebKit Misc.

Assignee:

Sungmann Cho <sungmann.cho>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Sungmann Cho

Reported 2015-10-18 18:11:52 PDT

The DLL build rules have been changed to generate "{Name}Lib.DLL", but these changes have not yet been applied to the Visual Studio builds.

Attachments
Patch (3.08 KB, patch) 2015-10-18 18:23 PDT, Sungmann Cho	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sungmann Cho

Comment 1 2015-10-18 18:23:07 PDT

Created attachment 263433 [details] Patch

Brent Fulgham

Comment 2 2015-10-18 18:41:11 PDT

You might need to take similar action for JSC.exe and DumpRebderTree.exe. Or, switch to CMake, which should work without further action. It generates a Visual Studio Solution.

Sungmann Cho

Comment 3 2015-10-18 19:12:12 PDT

Wow! When I switched to CMake, all my issues have been resolved. Thank you for letting me know!

WebKit Commit Bot

Comment 4 2015-10-18 19:26:58 PDT

Comment on attachment 263433 [details] Patch Clearing flags on attachment: 263433 Committed r191277: <http://trac.webkit.org/changeset/191277>

WebKit Commit Bot

Comment 5 2015-10-18 19:27:01 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.