Bug 15026

Summary: prepare-ChangeLog should list new tests in WebCore/ChangeLog
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Enhancement CC: darin, ddkilzer, sam
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch with ChangeLog
ddkilzer: review-
Updated to follow the style Darin mentioned ddkilzer: review+

Adam Roben (:aroben)
Reported 2007-08-20 14:22:55 PDT
prepare-ChangeLog should list any new regression tests in WebCore/ChangeLog (it already prints out a warning if no tests are added or changed). Patch coming.
Attachments
Patch with ChangeLog (4.64 KB, patch)
2007-08-20 14:26 PDT, Adam Roben (:aroben) 		ddkilzer: review-
DetailsFormatted DiffDiff
Updated to follow the style Darin mentioned (4.60 KB, patch)
2007-08-20 14:35 PDT, Adam Roben (:aroben) 		ddkilzer: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2007-08-20 14:26:34 PDT
Created attachment 16040 [details] Patch with ChangeLog For reference, here's how the list looks: 2007-08-20 Adam Roben <aroben@apple.com> Reviewed by NOBODY (OOPS!). Added tests: css1/basic/new-test.html fast/loader/yay.html
Darin Adler
Comment 2 2007-08-20 14:29:20 PDT
Comment on attachment 16040 [details] Patch with ChangeLog Adam, "Added xxx" is not the format we've been using for tests. Look at <http://trac.webkit.org/projects/webkit/changeset/25010> for an example of the format Maciej suggested and I've been following.
Adam Roben (:aroben)
Comment 3 2007-08-20 14:35:46 PDT
Created attachment 16041 [details] Updated to follow the style Darin mentioned Here's an updated patch that uses the "Test[s]:" format.
David Kilzer (:ddkilzer)
Comment 4 2007-08-20 14:36:18 PDT
Comment on attachment 16040 [details] Patch with ChangeLog r=me!
David Kilzer (:ddkilzer)
Comment 5 2007-08-20 14:36:48 PDT
Comment on attachment 16040 [details] Patch with ChangeLog Geez...you study the code for just a couple minutes.... :)
David Kilzer (:ddkilzer)
Comment 6 2007-08-20 14:39:14 PDT
Comment on attachment 16041 [details] Updated to follow the style Darin mentioned r=me!
Darin Adler
Comment 7 2007-08-20 14:39:34 PDT
Comment on attachment 16041 [details] Updated to follow the style Darin mentioned r=dkilzer (and me)
Adam Roben (:aroben)
Comment 8 2007-08-20 14:47:24 PDT
Landed as r25160
Note You need to log in before you can comment on or make changes to this bug.