Summary: | ASSERTION FAILED: markFontData in FontCascade::emphasisMarkHeight | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bugs-noreply, buildbot, commit-queue, darin, mcatanzaro, mmaxfield, mrobinson, rniwa, simon.fraser | ||||||||||||||
Priority: | P2 | Keywords: | LayoutTestFailure | ||||||||||||||
Version: | WebKit Local Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2015-10-15 08:30:35 PDT
Created attachment 263161 [details]
Patch
Comment on attachment 263161 [details]
Patch
The prefix [GTK] should not be used on a patch that affects platform-independent code. Lets take that prefix off this.
Myles, can you review this? Ok, I used the GTK prefix because the assert seems to only happen in the GTK+ bots, I don't know why. Comment on attachment 263161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263161&action=review > Source/WebCore/platform/graphics/FontCascade.cpp:1236 > + return !glyphData.isEmpty(); This function should return an Optional(GlyphData) instead of using an out param. Also, the U16_* macros can be cleaned up. > Source/WebCore/platform/graphics/GlyphPage.h:53 > + bool isEmpty() const { return !glyph && !font; } Why don't you name this "invalid" or something? I'm not sure that "empty" is the best name. Created attachment 263666 [details]
Patch for landing
Comment on attachment 263666 [details] Patch for landing Attachment 263666 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/315071 New failing tests: fast/text/emphasis.html fast/text/emphasis-combined-text.html Created attachment 263667 [details]
Archive of layout-test-results from ews102 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 263666 [details] Patch for landing Attachment 263666 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/315094 New failing tests: fast/text/emphasis.html fast/text/emphasis-combined-text.html Created attachment 263668 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 263666 [details] Patch for landing Attachment 263666 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/315102 New failing tests: fast/repaint/text-emphasis-h.html fast/text/emphasis.html fast/repaint/text-emphasis-v.html fast/text/emphasis-overlap.html fast/ruby/position-after.html fast/text/emphasis-avoid-ruby.html fast/text/emphasis-combined-text.html Created attachment 263670 [details]
Archive of layout-test-results from ews112 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 263671 [details]
Try to fix the tests
I assumed mark string was always 16 bit.
Comment on attachment 263671 [details] Try to fix the tests Clearing flags on attachment: 263671 Committed r191386: <http://trac.webkit.org/changeset/191386> All reviewed patches have been landed. Closing bug. |