Summary: | Binding generator should allow generating private JS functions | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | WebCore JavaScript | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | adam.bergkvist, cdumez, commit-queue, darin, eric.carlson | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2015-10-15 06:35:58 PDT
Created attachment 263152 [details]
Patch
Attachment 263152 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp:30: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
I used MediaDevices.getUserMedia as an example as it could be readily used for webkitGetUserMedia JS builtin implementation. See bug 149499. See bug 150166 for another related usecase. +1 for this feature Comment on attachment 263152 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263152&action=review > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:372 > + return 1 if ($function->signature->type eq "Promise"); No need for the parentheses. > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:374 > + return 1 if ($function->signature->type eq "Date"); Ditto. > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:376 > + return 1 if ($function->signature->extendedAttributes->{"JSBuiltin"}); Ditto. > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:378 > + return 1 if ($function->signature->extendedAttributes->{"Private"}); Ditto. > Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm:550 > + return 1 if ($function->signature->extendedAttributes->{"Private"}); No need for the parentheses. Created attachment 263463 [details]
Patch for landing
Comment on attachment 263463 [details] Patch for landing Clearing flags on attachment: 263463 Committed r191287: <http://trac.webkit.org/changeset/191287> All reviewed patches have been landed. Closing bug. |