Bug 150167 – Binding generator should allow generating private JS functions

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[youenn fablet]

JS builtins functions may need getting access to private JS functions implemented through DOM classes.
It may be convenient for the binding generator to support this.

[youenn fablet]

Created attachment 263152 [details]
Patch

[WebKit Commit Bot]

Attachment 263152 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp:30:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

I used MediaDevices.getUserMedia as an example as it could be readily used for webkitGetUserMedia JS builtin implementation.
See bug 149499.

[youenn fablet]

See bug 150166 for another related usecase.

[Adam Bergkvist]

+1 for this feature

[Darin Adler]

Comment on attachment 263152 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263152&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:372
> +    return 1 if ($function->signature->type eq "Promise");

No need for the parentheses.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:374
> +    return 1 if ($function->signature->type eq "Date");

Ditto.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:376
> +    return 1 if ($function->signature->extendedAttributes->{"JSBuiltin"});

Ditto.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:378
> +    return 1 if ($function->signature->extendedAttributes->{"Private"});

Ditto.

> Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm:550
> +    return 1 if ($function->signature->extendedAttributes->{"Private"});

No need for the parentheses.

[youenn fablet]

Created attachment 263463 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 263463 [details]
Patch for landing

Clearing flags on attachment: 263463

Committed r191287: <http://trac.webkit.org/changeset/191287>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.