Bug 150149 – Modern IDB: Handle versionchange events

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Brady Eidson]

Modern IDB: Add versionchange events

Now that we can commit version changes (https://bugs.webkit.org/show_bug.cgi?id=150147), we can have open database connections that can get versionchange events.

[Brady Eidson]

Created attachment 263301 [details]
Patch v1

[Alex Christensen]

Comment on attachment 263301 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=263301&action=review

> Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp:207
> +    scriptExecutionContext()->eventQueue().enqueueEvent(adoptRef(&event.leakRef()));

It seems like there might be a syntactically cleaner way to write.

[Brady Eidson]

(In reply to comment #2)
> Comment on attachment 263301 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=263301&action=review
> 
> > Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp:207
> > +    scriptExecutionContext()->eventQueue().enqueueEvent(adoptRef(&event.leakRef()));
> 
> It seems like there might be a syntactically cleaner way to write.

Sadly not right now - No clean way to automatically go from Ref to PassRefPtr.

Alas - The ugliness will be removed when PassRefPtr is purged completely!

[WebKit Commit Bot]

Comment on attachment 263301 [details]
Patch v1

Clearing flags on attachment: 263301

Committed r191198: <http://trac.webkit.org/changeset/191198>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

One of the new tests is failing:

--- /Volumes/Data/slave/elcapitan-release-tests-wk1/build/layout-test-results/storage/indexeddb/modern/versionchange-event-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk1/build/layout-test-results/storage/indexeddb/modern/versionchange-event-actual.txt
@@ -2,8 +2,8 @@
 ALERT: Version change complete (firstPhase). Database version is now - 1
 ALERT: Open success (secondPhase)
 ALERT: thirdPhase - Requested database connection with version 2
+ALERT: firstPhase connection versionchange event - old version: 1, new version: 2
 ALERT: secondPhase connection versionchange event - old version: 1, new version: 2
-ALERT: firstPhase connection versionchange event - old version: 1, new version: 2
 ALERT: Expected upgrade needed (thirdPhase)
 ALERT: Done
 This test:

[Ryan Haddad]

http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fmodern%2Fversionchange-event.html

[Brady Eidson]

The event order actually does not matter.
The test just needs to handle both orders.

I probably have a fix, but need to test it first, but need to finish my build first.

ETA: soon

[Brady Eidson]

https://trac.webkit.org/changeset/191222

[Ryan Haddad]

*** Bug 150259 has been marked as a duplicate of this bug. ***