Bug 150103 – [Win] Generate Crash Traces

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Brent Fulgham]

The test system has not been reliably generating crash traces on Windows. This seems to have started some time ago, and seems to be related to some bugs in the Python code as well as changes in the way MSVC deals with termination handlers.

This patch updates the test infrastructure so that we get crash traces more reliably.

[Brent Fulgham]

Created attachment 263030 [details]
Patch

[Daniel Bates]

Comment on attachment 263030 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263030&action=review

> Tools/ChangeLog:19
> +        (CrashLogs): Add another REGEX to handle a second crash trace syntax I

Nit: REGEX => regex or regular expression

> Tools/ChangeLog:21
> +        (CrashLogs._find_newest_log_win): If the old REGEX doesn't match, try

Ditto.

> Tools/ChangeLog:22
> +        the new one. The new REGEX finds a PID in HEX, so convert to integer.

Nit: REGEX => regex or regular expression
Nit: "in HEX" => "given as hexadecimal number"

> Tools/Scripts/webkitpy/common/system/crashlogs.py:37
> +    PID_LINE_REGEX2 = re.compile(r'Exit process \d+:(?P<pid>\w+), code')

This is OK as-is. Maybe a better name for PID_LINE_REGEX2 would be EXIT_PROCESS_PID_REGEX? We may also want to consider coming up with a better name for PID_LINE_REGEX. Maybe GLOBAL_PID_REGEX?

We may want to consider strengthening this regular expression to only accept ASCII hex digits for the PID instead of \w+.

[Brent Fulgham]

Comment on attachment 263030 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263030&action=review

>> Tools/ChangeLog:19
>> +        (CrashLogs): Add another REGEX to handle a second crash trace syntax I
> 
> Nit: REGEX => regex or regular expression

Will fix.

>> Tools/ChangeLog:21
>> +        (CrashLogs._find_newest_log_win): If the old REGEX doesn't match, try
> 
> Ditto.

Will fix.

>> Tools/ChangeLog:22
>> +        the new one. The new REGEX finds a PID in HEX, so convert to integer.
> 
> Nit: REGEX => regex or regular expression
> Nit: "in HEX" => "given as hexadecimal number"

Will fix.

>> Tools/Scripts/webkitpy/common/system/crashlogs.py:37
>> +    PID_LINE_REGEX2 = re.compile(r'Exit process \d+:(?P<pid>\w+), code')
> 
> This is OK as-is. Maybe a better name for PID_LINE_REGEX2 would be EXIT_PROCESS_PID_REGEX? We may also want to consider coming up with a better name for PID_LINE_REGEX. Maybe GLOBAL_PID_REGEX?
> 
> We may want to consider strengthening this regular expression to only accept ASCII hex digits for the PID instead of \w+.

I agree about the name changes, and will do so. I'll use GLOBAL_PID_REGEX and EXIT_PROCESS_PID_REGEX.

[Brent Fulgham]

Committed r191018: <http://trac.webkit.org/changeset/191018>