| Summary: | HTMLPreloadScanner should preload iframes | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||
| Component: | Page Loading | Assignee: | Chris Dumez <cdumez> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, gyuyoung.kim, koivisto, rniwa, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 155754 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Chris Dumez
2015-10-13 13:32:27 PDT
Created attachment 263023 [details]
Patch
I unfortunately did not see an impact on PLT locally. Comment on attachment 263023 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263023&action=review > LayoutTests/fast/preloader/frame-src.html:13 > +<html> > +<head> > +<script src="../../resources/js-test-pre.js"></script> > +<script src="http://127.0.0.1:8000/resources/slow-script.pl?delay=100"></script> > +<script> > + shouldBeTrue('internals.isPreloaded("resources/testFrame.html");'); > +</script> > +</head> > +<body> > +<p>Tests that iframes are preloaded.</p> > +<iframe src="resources/testFrame.html"></iframe> > +</body> > +</html> This test verifies that the iframe is preloaded but not that the preloaded resources is actually used (and doesn't just load again). Could you change it so that it verifies this too? This should happen even if the resource is uncacheable (as it often is). Created attachment 263091 [details]
Patch
Comment on attachment 263091 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263091&action=review > LayoutTests/fast/preloader/frame-src-expected.txt:2 > +testFrame.html has MIME type text/html I now dump the responses so we see the frame is only requested once. Is this sufficient or did you have something else in mind? Comment on attachment 263091 [details]
Patch
It would be also good to have the test ensure that this works when testFrame is served no-store (like it often is).
Created attachment 263167 [details]
Patch
(In reply to comment #7) > Comment on attachment 263091 [details] > Patch > > It would be also good to have the test ensure that this works when testFrame > is served no-store (like it often is). Added such test in the patch. Comment on attachment 263167 [details] Patch Attachment 263167 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/292013 New failing tests: fast/preloader/frame-src.html Created attachment 263172 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 263273 [details]
Patch
Comment on attachment 263273 [details] Patch Clearing flags on attachment: 263273 Committed r191180: <http://trac.webkit.org/changeset/191180> All reviewed patches have been landed. Closing bug. |