Bug 150091 – Avoid useless copies in range-loops that are using 'auto'

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Chris Dumez]

Avoid useless copies in range-loops that are using 'auto'. Also use 'auto*' instead of 'auto' when range values are pointers for clarity.

[Chris Dumez]

Created attachment 262992 [details]
Patch

[Darin Adler]

Comment on attachment 262992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262992&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:142
> -    for (auto track : stream.tracks()) {
> +    for (auto& track : stream.tracks()) {
>          m_MediaStreamPrivate->addTrack(WTF::move(track));

This one changes semantics, not just efficiency. Moving from a reference is different from moving from a copy. Hope that’s OK. I didn’t have time just now to look at the tracks() function to make sure it’s harmless.

> Source/WebKit2/UIProcess/WebProcessProxy.cpp:482
> +    for (auto& iter : m_pageURLRetainCountMap) {

The name iter is so lame.

[Chris Dumez]

Created attachment 263002 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 263002 [details]
Patch

Clearing flags on attachment: 263002

Committed r191002: <http://trac.webkit.org/changeset/191002>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.