Bug 150090 – Anonymous table objects: inline parent box requires inline-table child.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

17.2.1

For each proper table child C in a sequence of consecutive proper table children, if C is misparented then generate an anonymous 'table' or 'inline-table' box T around C and all consecutive siblings of C that are proper table children. (If C's parent is an 'inline' box, then T must be an 'inline-table' box; otherwise it must be a 'table' box.)

http://www.w3.org/TR/CSS21/tables.html

[alan]

Created attachment 262993 [details]
Patch

[Dave Hyatt]

Comment on attachment 262993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262993&action=review

r=me

> Source/WebCore/rendering/RenderInline.cpp:305
> +bool RenderInline::newChildIsInline(const RenderObject& newChild)
> +{
> +    // inline parent generates inline-table.
> +    return newChild.isInline() | (childRequiresTable(newChild) && style().display() == INLINE);
> +}

No need for this to be a member function IMO. It's just a helper for addChild, so could just be static in the .cpp file.

> Source/WebCore/rendering/RenderInline.h:184
> +    bool newChildIsInline(const RenderObject& newChild);

I don't think this needs to be in the header as an actual member.

[Build Bot]

Comment on attachment 262993 [details]
Patch

Attachment 262993 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/280061

New failing tests:
fast/dynamic/insert-before-table-part-in-continuation.html
fast/block/float/float-not-removed-from-pre-block.html
tables/mozilla/bugs/bug3037-1.html

[Build Bot]

Created attachment 263001 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 262993 [details]
Patch

Attachment 262993 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/280097

New failing tests:
fast/dynamic/insert-before-table-part-in-continuation.html
fast/block/float/float-not-removed-from-pre-block.html
tables/mozilla/bugs/bug3037-1.html

[Build Bot]

Created attachment 263004 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[alan]

Created attachment 263014 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 263014 [details]
Patch

Rejecting attachment 263014 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 263014, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Dave Hyatt found in /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/280575

[alan]

Created attachment 263025 [details]
Patch

[alan]

This changeset has missing Win and iOS test results. I'll update them later.

[WebKit Commit Bot]

Comment on attachment 263025 [details]
Patch

Clearing flags on attachment: 263025

Committed r191011: <http://trac.webkit.org/changeset/191011>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/23251212>