Bug 150060

Summary:

Refactor tune() to pass in an integer-based count

Product:

WebKit

Reporter:

Jon Lee <jonlee>

Component:

Animations

Assignee:

Jon Lee <jonlee>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, rniwa, sabouhallawa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

149053

Attachments:

Description	Flags
Patch	none
Patch	dino: review+

Description Jon Lee 2015-10-12 15:55:22 PDT

Tuning the # of objects to paint will always be integral.. All of the stages floor the delta count, so factor that logic out, and expect an integer count.

Comment 1 Radar WebKit Bug Importer 2015-10-12 15:55:59 PDT

<rdar://problem/23079435>

Comment 2 Jon Lee 2015-10-12 16:00:31 PDT

Created attachment 262935 [details]
Patch

Comment 3 Jon Lee 2015-10-12 17:04:36 PDT

Created attachment 262941 [details]
Patch

Comment 4 Said Abou-Hallawa 2015-10-12 17:09:13 PDT

Comment on attachment 262941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262941&action=review

> PerformanceTests/ChangeLog:24
> +        (LayeringTextStage.prototype.tune): Ditto.

Nice. informal r=me.

Comment 5 Jon Lee 2015-10-12 17:11:51 PDT

Committed r190908: <http://trac.webkit.org/changeset/190908>