Bug 15005
| Summary: | Nightly .zip for Windows contains .svn folders | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | 808caaa4.8ce9.9cd6c799e9f6 |
| Component: | WebKit Website | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Trivial | CC: | aroben, mrowe, webkit |
| Priority: | P5 | ||
| Version: | 523.x (Safari 3) | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
808caaa4.8ce9.9cd6c799e9f6
In WebInspector resource folders (for Windows) have .svn folders now.
Harmless for evaluation, of cource.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
Confirmed with WebKit-SVN-r25143.zip.
Adam Roben (:aroben)
This is happening because one of the post-build steps in WebCore.vcproj is:
xcopy /y /d /s "$(ProjectDir)\..\page\inspector\*" "$(WebKitOutputDir)\bin\WebKit.resources\inspector"
This command recursively copies everything beneath WebCore/page/inspector, including the .svn folder.
One way to fix this is to use the /exclude: flag. You pass it a file with a newline-separated list of patterns to exclude when copying. Any file matching any of the patterns will not be copied. I believe the pattern needed to exclude the .svn directory is this:
\.svn\
Robert Blaut
I've checked today nightly zip and found no more .svn folders. So the bug is already fixed.