Bug 149950

Summary:

[WinCairo][GStreamer] Hang on youtube.

Product:

WebKit

Reporter:

peavo

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

achristensen, bfulgham, bugs-noreply, cgarcia, mcatanzaro, pnormand, zan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	pnormand: review-

peavo

Reported 2015-10-09 04:14:42 PDT

The call to gst_element_set_state in the MediaPlayerPrivateGStreamer destructor never returns and blocks the main thread when the previous call to the function failed.

Attachments
Patch (1.96 KB, patch) 2015-10-09 04:29 PDT, peavo	pnormand: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

peavo

Comment 1 2015-10-09 04:29:58 PDT

Created attachment 262759 [details] Patch

Philippe Normand

Comment 2 2015-10-09 11:24:25 PDT

Comment on attachment 262759 [details] Patch The pipeline needs to be set to NULL state so that resources are correctly freed. This seems to be a work-around for a GStreamer bug. Can you please file a bug in GNOME's bugzilla if you manage to reproduce this issue outside of WebKit?

Philippe Normand

Comment 3 2015-10-09 11:28:58 PDT

If this is really specific to Youtube it would be nice to know if there's a deadlock somewhere, a session in the debugger could help figure this out :)

peavo

Comment 4 2015-10-09 12:39:23 PDT

(In reply to comment #3) > If this is really specific to Youtube it would be nice to know if there's a > deadlock somewhere, a session in the debugger could help figure this out :) Thanks for looking into this :) I will look further into this. What do you think about setting the NULL state from a thread to avoid blocking the main thread?

Michael Catanzaro

Comment 5 2017-05-02 09:33:03 PDT

Is this still a problem?

Alex Christensen

Comment 6 2017-05-08 10:14:29 PDT

Since WinCairo has its own media player implementation wrapping MediaFoundation now and nobody is actively using WinCairo with gstreamer, I'm going to say this isn't needed.

Note You need to log in before you can comment on or make changes to this bug.