Bug 149949

Summary: Fix webkitpy tests after r190779
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dewei_zhu, glenn, lforschler, ossy, rniwa
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149944    
Attachments:
Description Flags
Patch none

Description Csaba Osztrogonác 2015-10-09 02:01:53 PDT
https://trac.webkit.org/changeset/190779 broke 6 webkitpy tests.
Comment 1 Csaba Osztrogonác 2015-10-09 02:04:43 PDT
benchmark_results_unittest.BenchmarkResultsTest.test_format_values_with_no_error erred:
  Traceback (most recent call last):
    File "/home/webkit/WebKit/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py", line 101, in test_format_values_with_no_error
      self.assertEqual(BenchmarkResults._format_values('Time', [1, 1, 1]), '1.00ms stdev=0.0%')
  TypeError: _format_values() takes exactly 4 arguments (3 given)

[5/1442] webkitpy.benchmark_runner.benchmark_results_unittest.BenchmarkResultsTest.test_format_values_with_small_error erred:
  Traceback (most recent call last):
    File "/home/webkit/WebKit/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py", line 74, in test_format_values_with_small_error
      self.assertEqual(BenchmarkResults._format_values('Runs', [1.1, 1.2, 1.3]), '1.20/s stdev=8.3%')
  TypeError: _format_values() takes exactly 4 arguments (3 given)

[8/1442] webkitpy.benchmark_runner.benchmark_results_unittest.BenchmarkResultsTest.test_format_values_with_large_error erred:
  Traceback (most recent call last):
    File "/home/webkit/WebKit/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py", line 59, in test_format_values_with_large_error
      self.assertEqual(BenchmarkResults._format_values('Runs', [1, 2, 3]), '2.0/s stdev=50.0%')
  TypeError: _format_values() takes exactly 4 arguments (3 given)

[9/1442] webkitpy.benchmark_runner.benchmark_results_unittest.BenchmarkResultsTest.test_format erred:
  Traceback (most recent call last):
    File "/home/webkit/WebKit/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py", line 38, in test_format
      self.assertEqual(result.format(), 'SomeTest:Time: 2.0ms stdev=50.0%\n')
  TypeError: format() takes exactly 2 arguments (1 given)

[10/1442] webkitpy.benchmark_runner.benchmark_results_unittest.BenchmarkResultsTest.test_format_values_with_small_difference erred:
  Traceback (most recent call last):
    File "/home/webkit/WebKit/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py", line 104, in test_format_values_with_small_difference
      self.assertEqual(BenchmarkResults._format_values('Time', [5, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4]),
  TypeError: _format_values() takes exactly 4 arguments (3 given)

[11/1442] webkitpy.benchmark_runner.benchmark_results_unittest.BenchmarkResultsTest.test_format_values_with_time erred:
  Traceback (most recent call last):
    File "/home/webkit/WebKit/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py", line 89, in test_format_values_with_time
      self.assertEqual(BenchmarkResults._format_values('Time', [1, 2, 3]), '2.0ms stdev=50.0%')
  TypeError: _format_values() takes exactly 4 arguments (3 given)
Comment 2 Csaba Osztrogonác 2015-10-09 02:05:56 PDT
Created attachment 262757 [details]
Patch
Comment 3 Ryosuke Niwa 2015-10-09 02:06:40 PDT
Thanks for the fix!
Comment 4 Csaba Osztrogonác 2015-10-09 02:08:07 PDT
Comment on attachment 262757 [details]
Patch

Clearing flags on attachment: 262757

Committed r190782: <http://trac.webkit.org/changeset/190782>
Comment 5 Csaba Osztrogonác 2015-10-09 02:08:14 PDT
All reviewed patches have been landed.  Closing bug.