Bug 149944

Summary: Extend run-benchmark script to support human-readable results conversion.
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dewei_zhu, glenn, ossy, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 149949    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description dewei_zhu 2015-10-08 21:15:17 PDT
Extend run-benchmark script to support human-readable results conversion.
Comment 1 dewei_zhu 2015-10-08 21:19:52 PDT
Created attachment 262740 [details]
Patch
Comment 2 Ryosuke Niwa 2015-10-08 21:25:36 PDT
Comment on attachment 262740 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262740&action=review

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_results.py:98
> +            return ('{mean:.3f}{unit} stdev={delta:.1%}').format(
> +                mean=mean, delta=sample_stdev / mean, unit=unit)

This should fit in one line.

> Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:27
> +    parser.add_argument('--raw', action='store_true')

I don't think this is a descriptive name.
I'd call this --no-adjust-unit or --no-scale-unit and store the value in scaleUnit which defaults to True.

> Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:29
> +    mutual_group.add_argument('--format-result', dest='format_result', help='Specify file you want to format')

--format-results sound as if we wouldn't format results if we don't set this option.
--read-results-json?  --results-json?
Comment 3 dewei_zhu 2015-10-08 21:55:14 PDT
Created attachment 262744 [details]
Patch
Comment 4 WebKit Commit Bot 2015-10-08 22:53:45 PDT
Comment on attachment 262744 [details]
Patch

Clearing flags on attachment: 262744

Committed r190779: <http://trac.webkit.org/changeset/190779>
Comment 5 WebKit Commit Bot 2015-10-08 22:53:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Csaba Osztrogon√°c 2015-10-09 02:02:26 PDT
(In reply to comment #4)
> Comment on attachment 262744 [details]
> Patch
> 
> Clearing flags on attachment: 262744
> 
> Committed r190779: <http://trac.webkit.org/changeset/190779>

It broke 6 webkitpy tests, see bug149949 for details.