Web Inspector: Stack trace view doesn't properly display lines without function names

• Component: Web Inspector
• Status: RESOLVED FIXED

[Nikita Vasilyev]

Image: https://bugs.webkit.org/attachment.cgi?id=262414.

Note how the last line of the stack trace didn't get parsed correctly.

Expected:
(anonymous function) - error-prefix.html:27

Actual:
Full path, cannot be clicked.

[Radar WebKit Bug Importer]

<rdar://problem/23028382>

[Nikita Vasilyev]

Created attachment 262686 [details]
[HTML] Reduction

[Nikita Vasilyev]

Created attachment 262687 [details]
Patch

[Timothy Hatcher]

Comment on attachment 262687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262687&action=review

> Source/WebInspectorUI/UserInterface/Models/StackTrace.js:65
> +                ({url, lineNumber, columnNumber} = WebInspector.StackTrace._parseLocation(line.slice(atIndex + 1)));

Is the wrapping () needed here?

> Source/WebInspectorUI/UserInterface/Models/StackTrace.js:67
> +                ({url, lineNumber, columnNumber} = WebInspector.StackTrace._parseLocation(line));

Ditto.

[Joseph Pecoraro]

Comment on attachment 262687 [details]
Patch

It looks like this can be tested. Can we write a test for it?

[Nikita Vasilyev]

(In reply to comment #4)
> Comment on attachment 262687 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262687&action=review
> 
> > Source/WebInspectorUI/UserInterface/Models/StackTrace.js:65
> > +                ({url, lineNumber, columnNumber} = WebInspector.StackTrace._parseLocation(line.slice(atIndex + 1)));
> 
> Is the wrapping () needed here?
> 
> > Source/WebInspectorUI/UserInterface/Models/StackTrace.js:67
> > +                ({url, lineNumber, columnNumber} = WebInspector.StackTrace._parseLocation(line));
> 
> Ditto.

Yes! I was surprised to discover this too.

    var x = 0;
    {x} = {x: 2}; // SyntaxError: Unexpected token '='
    console.info(x);
    
This, however, works as you'd expect:

    var {x} = {x: 2};
    console.info(x); // 2

[Nikita Vasilyev]

Created attachment 262747 [details]
Patch (with a test)

[WebKit Commit Bot]

Comment on attachment 262747 [details]
Patch (with a test)

Clearing flags on attachment: 262747

Committed r190780: <http://trac.webkit.org/changeset/190780>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.