Bug 149847

Summary:

Refactor TokenPreloadScanner::StartTagScanner::processAttribute()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Page Loading

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, gyuyoung.kim, koivisto, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Chris Dumez 2015-10-06 09:36:29 PDT

Refactor TokenPreloadScanner::StartTagScanner::processAttribute() to only process attributes that make sense given the current tagId.

Comment 1 Chris Dumez 2015-10-06 09:41:35 PDT

Created attachment 262517 [details]
Patch

Comment 2 Antti Koivisto 2015-10-06 12:12:13 PDT

Comment on attachment 262517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262517&action=review

> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:155
> +            FALLTHROUGH;

It would be nicer to factor common things into a function rather than doing Img->Script fallthrough.

Comment 3 Chris Dumez 2015-10-06 13:17:28 PDT

Created attachment 262542 [details]
Patch

Comment 4 WebKit Commit Bot 2015-10-06 13:41:23 PDT

Comment on attachment 262542 [details]
Patch

Clearing flags on attachment: 262542

Committed r190641: <http://trac.webkit.org/changeset/190641>

Comment 5 WebKit Commit Bot 2015-10-06 13:41:28 PDT

All reviewed patches have been landed.  Closing bug.