Bug 149847

Summary: Refactor TokenPreloadScanner::StartTagScanner::processAttribute()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, gyuyoung.kim, koivisto, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2015-10-06 09:36:29 PDT
Refactor TokenPreloadScanner::StartTagScanner::processAttribute() to only process attributes that make sense given the current tagId.
Attachments
Patch (4.54 KB, patch)
2015-10-06 09:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.91 KB, patch)
2015-10-06 13:17 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-10-06 09:41:35 PDT
Created attachment 262517 [details] Patch
Antti Koivisto
Comment 2 2015-10-06 12:12:13 PDT
Comment on attachment 262517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262517&action=review > Source/WebCore/html/parser/HTMLPreloadScanner.cpp:155 > + FALLTHROUGH; It would be nicer to factor common things into a function rather than doing Img->Script fallthrough.
Chris Dumez
Comment 3 2015-10-06 13:17:28 PDT
Created attachment 262542 [details] Patch
WebKit Commit Bot
Comment 4 2015-10-06 13:41:23 PDT
Comment on attachment 262542 [details] Patch Clearing flags on attachment: 262542 Committed r190641: <http://trac.webkit.org/changeset/190641>
WebKit Commit Bot
Comment 5 2015-10-06 13:41:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.