Bug 149844
| Summary: | Web Inspector: Keyboard Shortcut ⌘⇧[ on non-english keyboards | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Niklas <n.brunberg> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Minor | CC: | ap, bburg, graouts, inspector-bugzilla-changes, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | OS X 10.10 | ||
Niklas
I arrived here from https://www.webkit.org/blog/4038/web-inspector-keyboard-shortcuts/
Because there is no [ key on some keyboard layouts modifier keys need to be pressed and this interferes with the keyboard shortcuts. E.g. on my Swedish keyboard to make the character '[' I need to press ⌥ and 8 in effect making ⌘⇧[ into ⌘⌥8 but that does not work unfortunately.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/22991113>
Joseph Pecoraro
⌘⇧] and ⌘⇧[ is actually more commonly shown as ⌘} and ⌘{. Do those key combinations work for you? Perhaps we should update the article.
Joseph Pecoraro
(In reply to comment #2)
> ⌘⇧] and ⌘⇧[ is actually more commonly shown as ⌘} and ⌘{. Do those key
> combinations work for you? Perhaps we should update the article.
That said, the keyboard combination actually requires Shift, even if a Brace is pressed:
> WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.RightCurlyBrace
So maybe we need to relax the Web Inspector code here.
Alexey Proskuryakov
As far as I know, brackets and curly braces should not be used in keyboard shortcuts because of their positioning on French keyboards (cf. <rdar://problem/5775865>).
With many other keyboard layouts like Swedish or German, curly braces are closer together, but poorly discoverable, because they are not embossed on key caps, and can only be typed with the Option key.
Joseph Pecoraro
(In reply to comment #4)
> As far as I know, brackets and curly braces should not be used in keyboard
> shortcuts because of their positioning on French keyboards (cf.
> <rdar://problem/5775865>).
>
> With many other keyboard layouts like Swedish or German, curly braces are
> closer together, but poorly discoverable, because they are not embossed on
> key caps, and can only be typed with the Option key.
This may be one reason why Terminal.app, Safari.app, and WebInspector all support multiple keyboard shortcuts to switch tabs.
The complete list that I know of for Safari and Web Inspector are:
Ctrl+Tab Shift+Ctrl+Tab
Cmd+} Cmd+{
Shift+Cmd+Right Shift+Cmd+Left
Niklas
> […] Do those key combinations work for you?
I have tried all combinations I can think of (including ⌘⌥8 and ⌘⌥⇧8) but not found a working set unless I switch keyboard layout.
Nikita Vasilyev
(In reply to comment #6)
> > […] Do those key combinations work for you?
>
> I have tried all combinations I can think of (including ⌘⌥8 and ⌘⌥⇧8) but
> not found a working set unless I switch keyboard layout.
Have you tried Ctrl+Tab and Shift+Ctrl+Tab?
Did it not work? Those should work with all keyboard layouts.
Niklas
(In reply to comment #7)
> (In reply to comment #6)
> > > […] Do those key combinations work for you?
> >
> > I have tried all combinations I can think of (including ⌘⌥8 and ⌘⌥⇧8) but
> > not found a working set unless I switch keyboard layout.
>
> Have you tried Ctrl+Tab and Shift+Ctrl+Tab?
> Did it not work? Those should work with all keyboard layouts.
Ctrl+Tab and Shift+Ctrl+Tab switches regular browser tabs even with the web inspector open and focus set in the web inspector.
Timothy Hatcher
None of the tab switching shortcuts work when docked currently, Safari always wins (we have another bug about that). If Ctrl-Tab works when the Inspector is windowed, then we can close this bug. The Ctrl-Tab shortcuts are the preferred tab switching shortcuts on OS X now because they are more universal across various international keyboards compared to the older shortcuts.
Niklas
(In reply to comment #9)
> None of the tab switching shortcuts work when docked currently, Safari
> always wins (we have another bug about that). If Ctrl-Tab works when the
> Inspector is windowed, then we can close this bug. The Ctrl-Tab shortcuts
> are the preferred tab switching shortcuts on OS X now because they are more
> universal across various international keyboards compared to the older
> shortcuts.
Unfortunately the keyboard shortcuts does not work when windowed either.
Blaze Burg
This behaves as expected when windowed with Swedish system language and Swedish input source. It doesn't work when docked and the Safari window has tabs, due to an existing bug. Closing now.