data: URLs should not be preloaded

• Component: Page Loading
• Status: RESOLVED FIXED

[Chris Dumez]

data: URLs should not be preloaded. The HTMLPreloadScanner currently preloads them but there is no need as the data is already available.

[Chris Dumez]

Created attachment 262493 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 262493 [details]
Patch

Clearing flags on attachment: 262493

Committed r190605: <http://trac.webkit.org/changeset/190605>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 262493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262493&action=review

> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:222
> +        if (m_urlToLoad.startsWith("data:", false))
> +            return false;

There’s a more optimized way to do this provided by URL.h:

    if (protocolIs(m_urlToLoad, "data"))

I also think we could add a protocolIsData function.

[Chris Dumez]

Reopening to attach new patch.

[Chris Dumez]

Created attachment 262638 [details]
Post-mortem review comments

[Build Bot]

Comment on attachment 262638 [details]
Post-mortem review comments

Attachment 262638 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/255207

New failing tests:
fast/preloader/image-data-url.html

[Build Bot]

Created attachment 262641 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 262638 [details]
Post-mortem review comments

Attachment 262638 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/255211

New failing tests:
fast/preloader/image-data-url.html

[Build Bot]

Created attachment 262643 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Chris Dumez]

Created attachment 262716 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 262716 [details]
Patch

Clearing flags on attachment: 262716

Committed r190755: <http://trac.webkit.org/changeset/190755>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.