Bug 149829

Summary: data: URLs should not be preloaded
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, gyuyoung.kim, koivisto, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Post-mortem review comments
none
Archive of layout-test-results from ews102 for mac-mavericks
none
Archive of layout-test-results from ews104 for mac-mavericks-wk2
none
Patch none

Chris Dumez
Reported 2015-10-05 21:07:29 PDT
data: URLs should not be preloaded. The HTMLPreloadScanner currently preloads them but there is no need as the data is already available.
Attachments
Patch (3.92 KB, patch)
2015-10-05 21:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Post-mortem review comments (1.34 KB, patch)
2015-10-07 13:58 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-mavericks (698.14 KB, application/zip)
2015-10-07 14:12 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (776.35 KB, application/zip)
2015-10-07 14:20 PDT, Build Bot 		no flags
Details
Patch (1.37 KB, patch)
2015-10-08 14:53 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-10-05 21:09:37 PDT
Created attachment 262493 [details] Patch
WebKit Commit Bot
Comment 2 2015-10-05 22:43:34 PDT
Comment on attachment 262493 [details] Patch Clearing flags on attachment: 262493 Committed r190605: <http://trac.webkit.org/changeset/190605>
WebKit Commit Bot
Comment 3 2015-10-05 22:43:39 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4 2015-10-07 09:32:35 PDT
Comment on attachment 262493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262493&action=review > Source/WebCore/html/parser/HTMLPreloadScanner.cpp:222 > + if (m_urlToLoad.startsWith("data:", false)) > + return false; There’s a more optimized way to do this provided by URL.h: if (protocolIs(m_urlToLoad, "data")) I also think we could add a protocolIsData function.
Chris Dumez
Comment 5 2015-10-07 13:58:49 PDT
Reopening to attach new patch.
Chris Dumez
Comment 6 2015-10-07 13:58:52 PDT
Created attachment 262638 [details] Post-mortem review comments
Build Bot
Comment 7 2015-10-07 14:12:51 PDT
Comment on attachment 262638 [details] Post-mortem review comments Attachment 262638 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/255207 New failing tests: fast/preloader/image-data-url.html
Build Bot
Comment 8 2015-10-07 14:12:55 PDT
Created attachment 262641 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 9 2015-10-07 14:20:14 PDT
Comment on attachment 262638 [details] Post-mortem review comments Attachment 262638 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/255211 New failing tests: fast/preloader/image-data-url.html
Build Bot
Comment 10 2015-10-07 14:20:17 PDT
Created attachment 262643 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Chris Dumez
Comment 11 2015-10-08 14:53:10 PDT
Created attachment 262716 [details] Patch
WebKit Commit Bot
Comment 12 2015-10-08 15:59:48 PDT
Comment on attachment 262716 [details] Patch Clearing flags on attachment: 262716 Committed r190755: <http://trac.webkit.org/changeset/190755>
WebKit Commit Bot
Comment 13 2015-10-08 15:59:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.