Bug 149827

Summary: Enable XSLT when building WebKit for iOS using the public iOS SDK
Product: WebKit Reporter: Daniel Bates <dbates>
Component: XMLAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cmarcelo, commit-queue, ddkilzer, dean_johnson, fred.wang, mitz, simon.fraser
Priority: P2    
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 9.0   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2015-10-05 20:30:28 PDT
We should enable XSLT when building WebKit for iOS with the public iOS SDK. This will make the public iOS SDK build of WebKit more closely resemble the version of WebKit that officially ships in iOS.
Attachments
Patch (9.78 KB, patch)
2015-10-05 20:32 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2015-10-05 20:32:50 PDT
Created attachment 262490 [details] Patch
Daniel Bates
Comment 2 2015-10-05 21:17:53 PDT
The iOS EWS fails to build this patch because the libxslt headers cannot be found. We need to land this patch and then run script configure-xcode-for-ios-development on the iOS EWS bots so that they can build with XSLT enabled.
Daniel Bates
Comment 3 2015-10-06 09:33:49 PDT
Comment on attachment 262490 [details] Patch Clearing flags on attachment: 262490 Committed r190617: <http://trac.webkit.org/changeset/190617>
Daniel Bates
Comment 4 2015-10-06 09:33:54 PDT
All reviewed patches have been landed. Closing bug.
mitz
Comment 5 2015-10-06 10:01:28 PDT
Mutating the iOS SDK seems unnecessarily intrusive. Can we instead follow the pattern used with ICU and have the headers live somewhere in the source tree? Or alternatively, can we set up a symlink from the derived sources directory into the OS X SDK and set up the header search paths such that the headers will be found?
Note You need to log in before you can comment on or make changes to this bug.